You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(pi): preserve image metadata for legacy DeepSeek selections - #225
Pi 1.2.0 can resolve the documented legacy DeepSeek Flash selection with text-only metadata, causing MCP images to be removed before the provider request. The Host extension uses the public session/turn hooks to select a copy of the native canonical model with the original alias ID, before image conversion. Explicit alias declarations and native/extension Provider registrations retain precedence; the selected endpoint, authentication and model ID remain native.
The compatibility repair is optional. A registry error can belong to an unrelated Provider rather than to models.json parsing. Such errors, unreadable/malformed declarations, an unavailable canonical model or a rejected/failed setModel now retain Pi's native selection, skip the repair for that Work and emit one fixed, sanitized warning. They do not become a fatal extension_error. The Host's normal extension-error handling is unchanged.
Validation of the review revision:
Native SDK metadata suite: 24 passed, retaining the previous 17 cases and adding error-boundary/multi-turn coverage.
Provider regression suite: 21 passed. Main's combined run: 45 passed; these counts overlap and are not additive.
Native TypeScript typecheck and git diff --check passed.
Regression RED on the unchanged production revision: 9 failed / 15 passed. The corrected revision covers unrelated malformed Provider configuration, declaration read/parse failures before and after native loading, setModel rejection/exception, explicit configuration precedence, repeated startup binding and two image-bearing turns. Failure cases preserve selection, emit no fatal extension_error, notify once and make no network requests.
These checks use the actual Pi 1.2.0 SDK and a deterministic completion stream. They do not claim a new desktop run, external model accuracy or raw provider HTTP capture. Remote CI on review commit 5b3a434 completed successfully: all 15 reported check runs passed. Earlier CI records remain associated with their original heads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi 1.2.0 can resolve the documented legacy DeepSeek Flash selection with text-only metadata, causing MCP images to be removed before the provider request. The Host extension uses the public session/turn hooks to select a copy of the native canonical model with the original alias ID, before image conversion. Explicit alias declarations and native/extension Provider registrations retain precedence; the selected endpoint, authentication and model ID remain native.
The compatibility repair is optional. A registry error can belong to an unrelated Provider rather than to models.json parsing. Such errors, unreadable/malformed declarations, an unavailable canonical model or a rejected/failed setModel now retain Pi's native selection, skip the repair for that Work and emit one fixed, sanitized warning. They do not become a fatal extension_error. The Host's normal extension-error handling is unchanged.
Validation of the review revision:
These checks use the actual Pi 1.2.0 SDK and a deterministic completion stream. They do not claim a new desktop run, external model accuracy or raw provider HTTP capture. Remote CI on review commit 5b3a434 completed successfully: all 15 reported check runs passed. Earlier CI records remain associated with their original heads.