Repository navigation
fix(build): isolate AEC source writes and preserve binding consistency - #249
Merged
Merged
Conversation
9 tasks
Lucas1479
marked this pull request as ready for review
October 20, 2026 15:05
Lucas1479
marked this pull request as draft
October 20, 2026 15:31
Lucas1479
marked this pull request as ready for review
October 20, 2026 15:47
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cold Linux Voice builds wrote Meson/setuptools output into the vendored source and could mix regenerated SWIG wrappers with older packaged Python proxies. Git updates can preserve those local binding changes.
Run setuptools hooks inside a disposable source copy, excluding prior build/install artifacts. Compile the committed wrapper/proxies after checking all three version headers before native work. Decode SWIG's decimal digit pairs correctly, including multi-digit version components, and fail with backup/restore guidance on mismatched or unreadable inputs. No user files are restored or deleted automatically. Preserve the Linux-only source selector and actual bundled Abseil 20240722.0 verification.
The qualifier requires Python 3.12 and uses the running interpreter for the locked install, both distribution builds, and an isolated wheel environment. Remove inherited RUST_LOG only from child environments so uv's verbose build evidence remains available. Linux CI deliberately sets RUST_LOG=warn while checking cold builds, source cleanliness, sdist/wheel contents, and the installed public native API. Provenance and upgrade documentation include the complete verified upstream patch and legacy-checkout cleanup steps.
Refs #247. The reporter completed the original Arch/system-Abseil-20260817 acceptance at
94b584c, including an independent clean-source/cache/environment retest: #247 (comment). The remaining log-filter issue from that report is addressed here. The maintainer will close #247 after merge.Validation:
dca7904c, all 16 checks across all six applicable workflows passed. The environment verifier reports all 110 core/dev packages compatible, and the existing-rule pip-audit reports no known vulnerabilities (the two existing ignored advisory aliases are unchanged).RUST_LOG=warn, two actual bundled-Abseil 20240722.0 confirmations, standalone wheel/native smoke, source cleanliness, and 242 contract tests. Linux/macOS Electron smoke each passed all 15 checks; Windows source and packaged smoke both passed with Startup mode saving verified. Windows full suites, the installation matrix, and source release passed. The reporter's Arch evidence remains specifically attributed to94b584c; this is not a claim of audio-device or acoustic-quality testing.The independent dependency update #252 is merged into main and incorporated here. These results are for the integrated head
dca7904cagainst main1d9e88df, rather than checks from an earlier revision.No runtime dependency upgrade or Windows/macOS registry-source change. SWIG's version encoding is documented at https://www.swig.org/Doc4.4/Preprocessor.html.