Repository navigation
fix(vn): qualify macOS Tk/ImageTk and document interpreter migration - #253
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Lucas1479
added a commit
that referenced
this pull request
Oct 21, 2026
…#250) Preserve the full Japanese pronunciation source as an independently versioned optional resource with validated corrections, explicit runtime deferrals, and install/update/rollback support. Fix personal dictionary precedence and normalization, base-case handling, numeric-hyphen boundaries, and large personal-dictionary startup scaling. Integrates main 879a8fb after #253 without conflicts; Japanese implementation remains identical to qualified 518475d. Validation: 154 related local tests and all 17 fresh CI checks passed on 3e06932. Prior four 26,552-record production profiles retain their evidence because the implementation is unchanged. The full rc2 resource and data history remain local and unpublished; this code merge does not publish or install the optional resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old uv-managed macOS Python builds can pass the package verifier but fail VN portrait startup at Tk initialization or Pillow ImageTk transfer. Document uv-managed CPython 3.12.14 and a reversible existing-.venv migration, and qualify the actual native image boundary in macOS CI.
Refs #223. Keep the issue open for the reporter's complete macOS VN Start acceptance; this PR does not close it automatically.
Validation:
UV_OFFLINE=1 python -X utf8 -m pytest -q tests/test_vn_portrait_environment.py tests/test_python_environment_verifier.py tests/test_profile_contract.py tests/test_core_install_tiers.py tests/test_vn_portrait_shared.py tests/test_vn_overlay_window_contract.py tests/test_vn_overlay_continuity.py).fa27de77: Darwin arm64, uv-managed CPython 3.12.14 (Clang 22.1.3), Pillow 13.0.0, Tcl/Tk 9.0.4. The real native RGBA probe passed; 281 contract tests passed (2 skipped), and Electron build and model-less desktop smoke passed.fa27de77c23bce07766d4d679c564613bb8dd495, including the three complete Python-suite partitions, Windows source/packaged desktop smoke, Linux and macOS desktop checks, and all installation profiles. Full game/OCR/audio acceptance remains with VN portrait fails to start on macOS with uv-managed Python 3.12.10 #223.b160d8ab: generated README overview and diff whitespace checks passed; both language entry points and the conditional preflight command were reviewed for consistency. Runtime, probe, tests and CI configuration are unchanged from the qualified commit above.b160d8ab: the first Windows partition 2 run failed in the unchangedtest_pi_cancel_cleanup.pyerror-publication case while decoding an emptyfinally.json. Three local runs of that file produced two complete passes, then a different permission-event startup timeout (8 passed / 1 failed overall); they did not reproduce the empty-JSON failure. No Pi code or assertions were changed. The single same-commit rerun passed the full partition, including all three Pi cancellation tests. All 15 checks are now successful onb160d8abb22fedfe788faded237efe721e700b78. The cause of the intermittent Pi integration-test results remains unestablished; this PR does not claim to fix it.