London | 25 -ITP-May | Dagim Daniel | Sprint 3 | implement and rewrite-test with jest by Dagim-Daniel · Pull Request #1473 · CodeYourFuture/Module-Structuring-and-Testing-Data

Dagim-Daniel · 2026-07-06T17:52:31Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

all tasks under sprint 3 - implement and rewrite-test with jest has been done

…only.

…-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks.

…t of get-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks." This reverts commit c822d53.

…en done

…-card-value adding line 37 to line 40 and i also completed the rewrite-test with jest section - i revert a commit so i work on it again and re- commit it( problem was the jest edited the jason file -version)

…fied get-card-value adding line 37 to line 40 and i also completed the rewrite-test with jest section - i revert a commit so i work on it again and re- commit it( problem was the jest edited the jason file -version)" This reverts commit 927466a.

LonMcGregor

Good work on these tasks. The implementations are working, but could be improved a bit more if you follow my comments

LonMcGregor · 2026-07-13T09:54:26Z

 function getAngleType(angle) {
  // TODO: Implement this function
+  if (angle>0 && angle<90)
+  {


Did you remember to format this code?

i didn't get you, LonMcGregor sorry

The indentation and organisation of symbols is a bit odd, did you run the formatter in your IDE before committing?

LonMcGregor · 2026-07-13T09:55:47Z

+  } 
+
+  const numvalue = Number(value);
+  if (numvalue >= 2 && numvalue <= 10) {


Does this if condition need to be here? (Hint: compare it to the earlier if conditions)

i guess so, because the other if condition was for throw error. with out this if condition it wouldn't give us the the numvalue within this scop

You already have an if check for >2 and <10, do you need both of them?

LonMcGregor

Still a few comments from me. Remember to add the "needs review" label after you make changes

LonMcGregor · 2026-07-20T09:10:54Z

+  } 
+
+  const numvalue = Number(value);
+  if (numvalue >= 2 && numvalue <= 10) {


You already have an if check for >2 and <10, do you need both of them?

LonMcGregor · 2026-07-20T09:11:27Z

 function getAngleType(angle) {
  // TODO: Implement this function
+  if (angle>0 && angle<90)
+  {


The indentation and organisation of symbols is a bit odd, did you run the formatter in your IDE before committing?

LonMcGregor

Thanks for updating this, I hope it makes sense how it is easier to read the code after these changes

Dagim-Daniel · 2026-07-20T15:19:03Z

Thanks for updating this, I hope it makes sense how it is easier to read the code after these changes

yeah, you are right, its easier to read now. thank you

Dagim-Daniel added 4 commits July 3, 2026 13:32

Sprint 3 from implement and rewrite - i have done the implement part …

e3ae6db

…only.

sprint 3 implement and rewrite - i modified the implement part of get…

c822d53

…-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks.

Revert "sprint 3 implement and rewrite - i modified the implement par…

3538f28

…t of get-card-value add line 37 to 40 and also done with the rewrite tests with jest tasks." This reverts commit c822d53.

Sprint 3 all tasks under implement and rewrite-tests with jest has be…

b37f1b2

…en done

Dagim-Daniel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 6, 2026

Sprint 3 implement and rewrite-test with jest is done, i modified get…

927466a

…-card-value adding line 37 to line 40 and i also completed the rewrite-test with jest section - i revert a commit so i work on it again and re- commit it( problem was the jest edited the jason file -version)

Dagim-Daniel added the 📅 Sprint 3 Assigned during Sprint 3 of this module label Jul 6, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

Dagim-Daniel added 2 commits July 6, 2026 19:53

Sprint 3 implement and rewrite-test with jest has been done

4d1bf8c

Dagim-Daniel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

LonMcGregor reviewed Jul 13, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026

refactoring the isProperFraction task

0b7c108

LonMcGregor reviewed Jul 20, 2026

View reviewed changes

fix the indentation and also fix getCardValue based on the comment

88db0dc

Dagim-Daniel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 20, 2026

LonMcGregor reviewed Jul 20, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

Dagim-Daniel commented Jul 6, 2026

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Dagim-Daniel commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LonMcGregor left a comment •

edited

Loading