Birmingham | 26-ITP-May | Ogbemi Mene | sprint 3 | 2-practice TDD coursework exercises#1491
Open
meneogbemi42-bit wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
changed the title
meneogbemi42-bit
added
Needs Review
meneogbemi42-bit
changed the title
cjyuan
reviewed
Jul 20, 2026
Comment on lines
+10
to
+13
| const pr = new Intl.PluralRules("en-US", { type: "ordinal" }); | ||
| const suffixes = { one: "st", two: "nd", few: "rd", other: "th" }; | ||
| const rule = pr.select(n); | ||
| return `${n}${suffixes[rule]}`; |
Contributor
There was a problem hiding this comment.
Interesting approach. Could you solve it without using any built-in API?
Comment on lines
+59
to
+65
| test("should append 'th' for all other numbers", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(20)).toEqual("20th"); | ||
| expect(getOrdinalNumber(34)).toEqual("34th"); | ||
| expect(getOrdinalNumber(100)).toEqual("100th"); | ||
| }); |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to. Can you revise the test description to make it more informative?
To make the test coverage more comprehensive, consider using arrays and loops (or other suitable Jest patterns) to test multiple values, ideally covering numbers that end with every possible digit in this category.
Author
There was a problem hiding this comment.
ok. take a look at the new commit i made if that meets the standard you want
cjyuan
added
Reviewed
Refactor tests for getOrdinalNumber to include cases for numbers ending in 0, 4, 5, 6, 7, 8, or 9.
meneogbemi42-bit
added
Needs Review
added 3 commits
July 22, 2026 17:01
…/github.com/meneogbemi42-bit/Module-Structuring-and-Testing-Data into Sprint-3/-Practice-TDD-Coursework-Exercises
meneogbemi42-bit
added
🏕 Priority Mandatory
cjyuan
reviewed
Jul 22, 2026
Comment on lines
+21
to
+25
| if (n < 0) { | ||
| positiveN = -n; | ||
| } else { | ||
| positiveN = n; | ||
| } |
Contributor
There was a problem hiding this comment.
-
Indentation is off.
-
Could also just use
Math.abs()
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
this PR demonstrates understanding of TDD:
Tests are written with explanatory comments, Implementation passes the test cases. Covers edge cases (negative numbers, teens exceptions), Clean, readable code structure.