Manchester | 26-ITP-May | Abdu Hassen | Sprint 3 |practice-tdd #1500
Open
Abduhasen wants to merge 1 commit into
Open
Manchester | 26-ITP-May | Abdu Hassen | Sprint 3 |practice-tdd #1500Abduhasen wants to merge 1 commit into
Abduhasen wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Abduhasen
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Abduhasen
changed the title
Abduhasen
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks, I have some comments for you to improve further
| // And a character `char` that does not exist within `str`. | ||
| // When the function is called with these inputs, | ||
| // Then it should return 0, indicating that no occurrences of `char` were found. | ||
| test("should count multiple occurrences of a character", () => { |
There was a problem hiding this comment.
Do these test descriptions accurately describe these tests?
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(33)).toEqual("33rd"); | ||
| expect(getOrdinalNumber(133)).toEqual("133rd"); | ||
| }); |
There was a problem hiding this comment.
Do your tests check for all possible if branches?
| for (let i = 0; i < num; i++) { | ||
| result += str; | ||
| } | ||
| if (num > 0) { |
There was a problem hiding this comment.
Are all of these if branches necessary?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iven development
Learners, PR Template
Self checklist
Changelist
-writing test
-writing code based on tests
Questions
N/A