-
-
Notifications
You must be signed in to change notification settings - Fork 395
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 3 | 2-practice-tdd #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let countTime = 0; | ||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] == findCharacter) {//take each character out from string to compare with the given character. If true, then add one to countTime. | ||
| countTime = countTime + 1; | ||
| } | ||
| } | ||
| return countTime; | ||
| } | ||
|
|
||
| module.exports = countChar; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,22 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| let onesDigit = Number(String(num).slice(-1)); //extract the figure at the tens digit, and convert it into a number. | ||
| let tensDigit; | ||
| if (String(num).length > 1) { | ||
| tensDigit = Number(String(num).slice(-2, -1)); //extract the figure at the tens digit, and convert it into a number. | ||
| } | ||
| if (tensDigit === 1) { | ||
| return num + "th"; | ||
| } else { | ||
| if (onesDigit === 1) { | ||
| return num + "st"; | ||
| } else if (onesDigit === 2) { | ||
| return num + "nd"; | ||
| } else if (onesDigit === 3) { | ||
| return num + "rd"; | ||
| } else { | ||
| return num + "th"; | ||
| } | ||
| } | ||
|
Comment on lines
+4
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a mostly working solution, but with a lot of nested if statements it can be quite hard to follow the logic of it. A few things to consider:
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for guiding me on this problem. I am having some insights for how to make this kind of statement in the future. |
||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,43 @@ const getOrdinalNumber = require("./get-ordinal-number"); | |
| // Case 1: Numbers ending with 1 (but not 11) | ||
| // When the number ends with 1, except those ending with 11, | ||
| // Then the function should return a string by appending "st" to the number. | ||
| test("should append 'st' for numbers ending with 1, except those ending with 11", () => { | ||
| test("should append 'st' for numbers ending with 1, except those having figure 1 in tens digit", () => { | ||
| expect(getOrdinalNumber(1)).toEqual("1st"); | ||
| expect(getOrdinalNumber(21)).toEqual("21st"); | ||
| expect(getOrdinalNumber(131)).toEqual("131st"); | ||
| }); | ||
|
|
||
| test("should append 'nd' for numbers ending with 2, except those having figure 1 in tens digit", () => { | ||
| expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
| expect(getOrdinalNumber(22)).toEqual("22nd"); | ||
| expect(getOrdinalNumber(132)).toEqual("132nd"); | ||
| }); | ||
|
|
||
| test("should append 'rd' for numbers ending with 3, except those having figure 1 in tens digit", () => { | ||
| expect(getOrdinalNumber(3)).toEqual("3rd"); | ||
| expect(getOrdinalNumber(23)).toEqual("23rd"); | ||
| expect(getOrdinalNumber(133)).toEqual("133rd"); | ||
| }); | ||
|
|
||
| test("should append 'th' for other numbers ending with 1,2 or 3, except those having figure 1 in tens digit", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| expect(getOrdinalNumber(113)).toEqual("113th"); | ||
| expect(getOrdinalNumber(213)).toEqual("213th"); | ||
| expect(getOrdinalNumber(313)).toEqual("313th"); | ||
| expect(getOrdinalNumber(1113)).toEqual("1113th"); | ||
| }); | ||
|
Comment on lines
+21
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These tests are pretty good! Though every assertion here ends in 1, 2, or 3. If you added an assertion with a number ending in a 4, what would happen? Would it pass?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I missed the regular case and now added back this test. |
||
|
|
||
| test("should append 'th' for other numbers ending other than 1,2 or 3", () => { | ||
| expect(getOrdinalNumber(5)).toEqual("5th"); | ||
| expect(getOrdinalNumber(8)).toEqual("8th"); | ||
| expect(getOrdinalNumber(9)).toEqual("9th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(57)).toEqual("57th"); | ||
| expect(getOrdinalNumber(79)).toEqual("79th"); | ||
| expect(getOrdinalNumber(94)).toEqual("94th"); | ||
| expect(getOrdinalNumber(266)).toEqual("266th"); | ||
| expect(getOrdinalNumber(465)).toEqual("465th"); | ||
| expect(getOrdinalNumber(1070)).toEqual("1070th"); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,15 @@ | ||
| function repeatStr() { | ||
| function repeatStr(str, count) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| let strOutput = ""; | ||
| if (count >= 0){ | ||
| for (let i=0 ; i<count ; i++){ | ||
| strOutput = strOutput + str; | ||
| } | ||
| return strOutput; | ||
| }else{ | ||
| throw new Error("Negative count is not valid"); | ||
| } | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely works! But
is quite a lengthy way to access a single character in a string. Can you think of a simpler way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I think I make things complicated again. Thanks!