Skip to content

test(studio): pin English in the studio test app - #179

Open
fix2it wants to merge 8 commits into
CodeZeno:mainfrom
fix2it:fix/studio-tests-english
Open

fix2it wants to merge 8 commits into
CodeZeno:mainfrom
fix2it:fix/studio-tests-english

Conversation

@fix2it

@fix2it fix2it commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Pins the test harness language to English (en-US) in studio_app::tests::app_with_surfaces so that UI string assertions pass consistently on non-English Windows environments.

Problem

Previously, app_with_surfaces initialized StudioApp with default settings (SettingsFile::default()), which inherits the OS UI language. On non-English Windows installations (such as Russian, Japanese, etc.), two tests failed due to localized string mismatches:

  • studio_app::tests::version_text_and_trailing_icon_share_one_update_button
  • studio_app::tests::diagnostics_page_has_logging_controls_and_menu_version

(Note: this was also observed and noted by contributors in #173).

Key Changes

  • In src/studio_app/tests.rs, explicitly set settings.language = Some("en-US".into()) during test harness initialization.

Verification

  • cargo test --lib studio_app::tests now passes 100% on non-English Windows locales.

fix2it and others added 8 commits October 18, 2026 22:34
duration_short truncated to whole units, so 4d23h read "4d" and 59m40s
could not be told from 59m. It now rounds: half steps below 10 h and
10 d (1.5ч, 2.5д), whole units above, minutes clamped to 59 so the next
step is "1h", and 23h45m rolls over to "1d".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.151 to 1.0.154.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.151...v1.0.154)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-version: 1.0.154
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lucide-icons](https://github.com/WhySoBad/lucide-icons-rs) from 1.52.0 to 1.55.0.
- [Commits](https://github.com/WhySoBad/lucide-icons-rs/commits)

---
updated-dependencies:
- dependency-name: lucide-icons
  dependency-version: 1.55.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [winresource](https://github.com/BenjaminRi/winresource) from 0.1.31 to 0.1.34.
- [Commits](https://github.com/BenjaminRi/winresource/commits)

---
updated-dependencies:
- dependency-name: winresource
  dependency-version: 0.1.34
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix(theme): математическое округление времени сброса
fix(antigravity): надежное чтение пула Gemini из Quota Summary
feat(antigravity): раздельный учет пулов Gemini и Claude/GPT
Two UI text assertions followed the system language and failed on
non-English Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant