Skip to content

Updated styles for responsive visibility - #3024

Open
girishpanchal30 wants to merge 2 commits into
developmentfrom
bugfix/2940
Open

Updated styles for responsive visibility#3024
girishpanchal30 wants to merge 2 commits into
developmentfrom
bugfix/2940

Conversation

@girishpanchal30

Copy link
Copy Markdown
Contributor

Closes #2940

Summary

Updated the inline CSS to wrap the hide-on-* rules in the @layer utilities block and use a :not(#_) selector, ensuring these rules have higher specificity and reliably override Tailwind's !important utilities.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@pirate-bot

Copy link
Copy Markdown
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 178.33 KB 178.33 KB 0 B (0.00%)
Blocks 1.65 MB 1.65 MB 0 B (0.00%)
CSS 7.83 KB 7.83 KB 0 B (0.00%)
Dashboard 172.49 KB 172.49 KB 0 B (0.00%)
Onboarding 68.14 KB 68.14 KB 0 B (0.00%)
Export Import 4.73 KB 4.73 KB 0 B (0.00%)
Pro 439.82 KB 439.82 KB 0 B (0.00%)

@pirate-bot

pirate-bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Plugin build for 5d17458 is ready 🛎️!

@pirate-bot

pirate-bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

E2E Tests

Playwright Test Status: See serial and parallel matrix jobs

Performance Results serverResponse: {"q25":545.82,"q50":563.97,"q75":569.4,"cnt":10}, firstPaint: {"q25":1700.6,"q50":1808.02,"q75":2090.47,"cnt":10}, domContentLoaded: {"q25":4417.57,"q50":4438.39,"q75":4472.06,"cnt":10}, loaded: {"q25":4421.46,"q50":4441.93,"q75":4475.42,"cnt":10}, firstContentfulPaint: {"q25":2987.6,"q50":3332.66,"q75":3380.97,"cnt":10}, firstBlock: {"q25":20297.42,"q50":20546.54,"q75":21167.77,"cnt":10}, type: {"q25":33.72,"q50":38.11,"q75":43.01,"cnt":10}, typeWithoutInspector: {"q25":31.63,"q50":33.88,"q75":37.46,"cnt":10}, typeWithTopToolbar: {"q25":41.37,"q50":45.48,"q75":48.57,"cnt":10}, typeContainer: {"q25":18.55,"q50":20.19,"q75":20.55,"cnt":10}, focus: {"q25":162.9,"q50":170.55,"q75":182.87,"cnt":10}, inserterOpen: {"q25":56.46,"q50":58.02,"q75":64.05,"cnt":10}, inserterSearch: {"q25":33.57,"q50":37.1,"q75":39.54,"cnt":10}, inserterHover: {"q25":6.52,"q50":7.52,"q75":8.6,"cnt":20}, loadPatterns: {"q25":2256.4,"q50":2276.68,"q75":2400.2,"cnt":10}, listViewOpen: {"q25":294.57,"q50":306.17,"q75":315.43,"cnt":10}

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates responsive visibility CSS to override Atomic Wind’s important display utilities.

Changes:

  • Adds layered, higher-specificity hide rules.
  • Adds frontend regression tests across responsive viewports.
  • Serializes tests that modify the Atomic Wind setting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
inc/class-registration.php Strengthens responsive hide CSS.
src/blocks/test/e2e/blocks/atomic-wind-hide-conditions.spec.js Tests visibility against flex.
src/blocks/test/e2e/playwright.config.js Runs the new test serially.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread inc/class-registration.php Outdated
Comment thread src/blocks/test/e2e/blocks/atomic-wind-hide-conditions.spec.js

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Atomic Wind flex utility overrides responsive block visibility

4 participants