Updated styles for responsive visibility - #3024
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 5d17458 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: See serial and parallel matrix jobs Performance ResultsserverResponse: {"q25":545.82,"q50":563.97,"q75":569.4,"cnt":10}, firstPaint: {"q25":1700.6,"q50":1808.02,"q75":2090.47,"cnt":10}, domContentLoaded: {"q25":4417.57,"q50":4438.39,"q75":4472.06,"cnt":10}, loaded: {"q25":4421.46,"q50":4441.93,"q75":4475.42,"cnt":10}, firstContentfulPaint: {"q25":2987.6,"q50":3332.66,"q75":3380.97,"cnt":10}, firstBlock: {"q25":20297.42,"q50":20546.54,"q75":21167.77,"cnt":10}, type: {"q25":33.72,"q50":38.11,"q75":43.01,"cnt":10}, typeWithoutInspector: {"q25":31.63,"q50":33.88,"q75":37.46,"cnt":10}, typeWithTopToolbar: {"q25":41.37,"q50":45.48,"q75":48.57,"cnt":10}, typeContainer: {"q25":18.55,"q50":20.19,"q75":20.55,"cnt":10}, focus: {"q25":162.9,"q50":170.55,"q75":182.87,"cnt":10}, inserterOpen: {"q25":56.46,"q50":58.02,"q75":64.05,"cnt":10}, inserterSearch: {"q25":33.57,"q50":37.1,"q75":39.54,"cnt":10}, inserterHover: {"q25":6.52,"q50":7.52,"q75":8.6,"cnt":20}, loadPatterns: {"q25":2256.4,"q50":2276.68,"q75":2400.2,"cnt":10}, listViewOpen: {"q25":294.57,"q50":306.17,"q75":315.43,"cnt":10} |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates responsive visibility CSS to override Atomic Wind’s important display utilities.
Changes:
- Adds layered, higher-specificity hide rules.
- Adds frontend regression tests across responsive viewports.
- Serializes tests that modify the Atomic Wind setting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
inc/class-registration.php |
Strengthens responsive hide CSS. |
src/blocks/test/e2e/blocks/atomic-wind-hide-conditions.spec.js |
Tests visibility against flex. |
src/blocks/test/e2e/playwright.config.js |
Runs the new test serially. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Soare-Robert-Daniel
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2940
Summary
Updated the inline CSS to wrap the hide-on-* rules in the
@layer utilitiesblock and use a:not(#_)selector, ensuring these rules have higher specificity and reliably override Tailwind's!importantutilities.Checklist before the final review