Repository navigation
fix(client): add system text to compaction and generate requests - #54
Merged
Merged
Conversation
OpenCode 2 builds compaction and generate (warming) requests through their own session hooks, not context. Registering only on context left those requests with a shorter system block, so they missed the provider's prompt cache and prefilled the conversation again. Fixes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53.
On OpenCode 2, Cockpit's agent halves (Review, Shell, Trail) added their system text only through the session
contexthook. OpenCode builds compaction andgenerate(warming) requests through separatecompactionandgeneratehooks, so those requests had a different system block and missed the provider's prompt cache. OpenCode fixed the same problem in its own plugins in anomalyco/opencode#48749.Change
dualServerregisters the same handler oncontext,compactionandgenerate.V2ServerContext.session.hooknow accepts all three names.The hook split landed before OpenCode 2.0.0, so every 2.x release has it. OpenCode 1 is unchanged.
Verified
session.compact.mainbun run check: 2,554 pass, 0 fail.