fix(release): parse Grype 0.110 nested db.status identity - #170
Merged
Conversation
Grype >= 0.110 nests the vulnerability database identity under descriptor.db.status (built / schemaVersion / checksum inside the from URL); release_evidence.py still read the pre-0.110 flat db layout and failed the v1.6 release run with "container vulnerability database identity is incomplete" after every other gate had passed. Accept both shapes: when db.status is a mapping, merge its fields over the flat ones before validating. Adds a regression test using the exact structure emitted by scan-action/Grype 0.110.0 in run 32860273692. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de500506f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…: false) Codex review P1 on #170: the db.status merge ignored the scanner-declared validity flag, so an invalid-database report with zero matches could pass the severity gate and ship as release security evidence. Reject such reports explicitly; adds a regression test. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Owner
Author
|
Fixed in ba8c991: `db.status.valid: false` now raises EvidenceError ("container vulnerability database is marked invalid by the scanner") before identity validation, with a regression test using the exact 0.110 status shape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(release): parse Grype 0.110 nested db.status identity
Grype >= 0.110 nests the vulnerability database identity under
descriptor.db.status (built / schemaVersion / checksum inside the from
URL); release_evidence.py still read the pre-0.110 flat db layout and
failed the v1.6 release run with "container vulnerability database
identity is incomplete" after every other gate had passed.
Accept both shapes: when db.status is a mapping, merge its fields over
the flat ones before validating. Adds a regression test using the exact
structure emitted by scan-action/Grype 0.110.0 in run 32860273692.
Co-authored-by: CommandCodeBot noreply@commandcode.ai