Repository navigation
Tests: exercise automatic browser access instead of URL tokens - #301
Merged
Merged
Conversation
The dashboard no longer exchanges a deployment token from a URL fragment, so the e2e specs that navigated with #token=<ENGRAPHIS_API_TOKEN> were exercising a dead path while the automatic session did the real work. Open the dashboard directly and let the shipped automatic-session path run, including the Firefox/WebKit smoke. The deliberate obsolete-fragment test in ask-home.spec.js and the mocked one-time handoff test in ledger.spec.js remain.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #296 the dashboard no longer exchanges a deployment token from a URL fragment; it opens automatically for a browser that reaches it. Six e2e specs still navigated with
#token=engraphis-playwright-local-only, which was dead weight: the client captured and discarded the fragment while the automatic session did the real work. It also meant the Firefox/WebKit smoke never exercised the shipped automatic path.What changed
workspace-smoke,ask-home,history-project,ledger-features,memory-workflow,workspace-routingnow open the dashboard directly (/or/?view=…), so the automatic-session path runs under chromium, firefox, and webkit.ledger-featuresrenamesTOKEN_URLtoDASHBOARD_URLand its comment no longer describes a token exchange.ask-home's "local boot removes obsolete token fragments while retaining navigation context" test, which asserts the fragment is stripped andpanel=evidencesurvives.ledger.spec.js's mocked one-time handoff test.Verification