Skip to content

Skip the million-row TreeDataGrid test in WebKit #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nstepien merged 2 commits into from
Oct 25, 2026
Merged

Skip the million-row TreeDataGrid test in WebKit #4232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31af991
Skip the million-row TreeDataGrid test in WebKit
nstepien Oct 25, 2026
33f66a3
Merge branch 'main' into webkit-skip-million-rows
nstepien Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 33 additions & 26 deletions test/browser/TreeDataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useState } from 'react';
import { page, userEvent } from 'vite-plus/test/browser';
import { page, server, userEvent } from 'vite-plus/test/browser';

import type { Column } from '../../src';
import { renderTextEditor, SelectColumn, TreeDataGrid } from '../../src';
Expand Down Expand Up @@ -222,32 +222,39 @@ test('should use groupBy order while grouping', async () => {
await testRowCount(5);
});

test('should expand a group with more rows than a function call can take as arguments', async () => {
// browsers limit the number of arguments, e.g., in `push(...childRows)`, and a million is above all of their limits
const rows = Array.from({ length: 1_000_000 }, (_, id): Row => ({
id,
country: 'USA',
year: 2020
}));

await page.render(
<TreeDataGrid
columns={[
{ key: 'country', name: 'Country' },
{ key: 'id', name: 'Id' }
]}
rows={rows}
groupBy={['country']}
expandedGroupIds={new Set(['USA'])}
onExpandedGroupIdsChange={() => {}}
/>
);
// WebKit lays out each row track of the grid, so a million rows take ~250ms per layout
// and ~1 GB of memory, and the page keeps over half of it after the test.
// The tested code doesn't depend on the browser, and Chromium and Firefox have lower limits.
test(
'should expand a group with more rows than a function call can take as arguments',
{ skip: server.browser === 'webkit' },
async () => {
// browsers limit the number of arguments, e.g., in `push(...childRows)`, and a million is above all of their limits
const rows = Array.from({ length: 1_000_000 }, (_, id): Row => ({
id,
country: 'USA',
year: 2020
}));

await page.render(
<TreeDataGrid
columns={[
{ key: 'country', name: 'Country' },
{ key: 'id', name: 'Id' }
]}
rows={rows}
groupBy={['country']}
expandedGroupIds={new Set(['USA'])}
onExpandedGroupIdsChange={() => {}}
/>
);

// the header row, the group row, and the rows of the group
await expect.element(treeGrid).toHaveAttribute('aria-rowcount', '1000002');
// the row count doesn't depend on the expanded state, so also check that the rows were added
await expect.element(page.getCell({ name: '0', exact: true })).toBeVisible();
});
// the header row, the group row, and the rows of the group
await expect.element(treeGrid).toHaveAttribute('aria-rowcount', '1000002');
// the row count doesn't depend on the expanded state, so also check that the rows were added
await expect.element(page.getCell({ name: '0', exact: true })).toBeVisible();
}
);

test('should keep the row keys when an earlier group is expanded, without rowKeyGetter', async () => {
function Test() {
Expand Down
Loading