docs(errors): attribute the detail[] validation shape to FastAPI - #123
Conversation
The `detail[]` body with `loc`/`msg`/`type` is FastAPI's own validation error format. Naming a specific third-party API alongside it implied the shape originates there, which is not where it comes from and is not what this SDK is describing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe pull request updates one test comment to match the FastAPI ChangesValidation comment
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a comment-only documentation correction in a test file with no product or runtime behavior change; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
mattmillerai
added
the
full-autonomy
robinjhuang
left a comment
robinjhuang
left a comment
There was a problem hiding this comment.
Auto-approved under the full-autonomy policy.
Gates verified at d779d6d5c90d10488f8fe40ab3aa2167b32e4d7e:
full-autonomylabel present- assigned to, or review requested from, @robinjhuang
- not a draft
- 8 required check(s) green — none failing, none pending
Issued by full-autonomy-approve.yml (run). This approval attests
that the machine gates above passed at this commit. It does not attest that a
human read the diff.
2 participants
Summary
One comment change, no behaviour.
tests/test_error_mapping.pydescribed Router's per-field validation body as the "fal/FastAPIdetail[]shape". Thedetail[]body carryingloc/msg/typeis FastAPI's own validation error format. Naming a specific third-party API next to it implied the shape originates there, which is both inaccurate and more than this SDK needs to say about where a wire format came from.Dropping the vendor name leaves the attribution correct: this is the FastAPI shape, and Router happens to serve it.
Verification
Comment-only.
tests/test_error_mapping.pycompiles and the assertions around it are unchanged.Summary by CodeRabbit