Repository navigation
chore: sync vendored Comfy Router spec (cloud@4b6dc810) - #226
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 23, 2026 03:36
9976b91 to
b9d2e28
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 23, 2026 17:14
b9d2e28 to
6f53e8a
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 24, 2026 10:13
6f53e8a to
3f5bc67
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 25, 2026 16:06
3f5bc67 to
cb4cb4f
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 26, 2026 20:53
cb4cb4f to
28a129d
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
2 times, most recently
from
October 27, 2026 08:15
ea5459c to
635b549
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 27, 2026 15:48
635b549 to
9665cb3
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 27, 2026 16:46
9665cb3 to
cc58bdc
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 27, 2026 18:23
cc58bdc to
f615bca
Compare
The synced spec adds the `result_expired` bucket: a queued request that finished but whose result is no longer stored, answered 410 and permanent for that request id. Add `ResultExpired` to the closed class table in spec order, blessed against the entry's `meaning`, so the bucket reaches callers typed rather than as a bare `RouterError`.
mattmillerai
force-pushed
the
chore/sync-router-spec
branch
from
October 27, 2026 19:04
7e6be76 to
894b09e
Compare
vqt123
approved these changes
Oct 28, 2026
vqt123
left a comment
Contributor
There was a problem hiding this comment.
Spec sync plus the matching ResultExpired class for the new result_expired bucket (410); tests cover the mapping, checks green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of the public Comfy Router spec, projected from the canonical contract (internal notes stripped). Source:
cloud@4b6dc810.It lands at
spec/router-openapi.yamland is a contract of its own — it is never merged into another vendored spec in this repo.This is the single rolling sync pull request for
spec/router-openapi.yaml. It liveson
chore/sync-router-spec, and every later change to the upstream contractforce-updates this same branch and refreshes this description with the
new source commit — so there is only ever one open sync PR for this
spec, and its diff is always the current one.
The error-type class commit described above is the one commit that
belongs here. Once a commit of yours is on this branch, the next sync
refuses to force-update it and fails, naming this pull request, so
land this pull request promptly. Push any other follow-up work to a
branch of your own.
No Router operations are currently unserved (as of
cloud@4b6dc810).This note auto-refreshes while this PR is open: a change to comfy-api's
exclude list rewrites this section in place, and a change to the
PUBLISHED Router surface opens its own sync PR carrying the set as of
ITS commit. Once this PR is merged the note is a permanent snapshot —
for the current state, check
services/comfy-api/drip/codegen.yamlinComfy-Org/cloud directly.
No code generation for this spec yet. Nothing in this repo
generates code from
spec/router-openapi.yaml, so this sync has no low layer toregenerate and the workflow that opened this pull request could not
prepare one for you.
That is not the same as nothing to do. This repo keeps a hand-written
surface coupled to this contract — its error-type class table — with
a drift check of its own, so a sync that adds an error bucket still
needs a commit here before this pull request goes green. When code
generation does land for this spec, its command is configured
upstream, in the same sync workflow that opened this PR, and this
section becomes the automatic one.
Commit that class to this branch and land this pull request once it
is green. The class cannot land separately: the drift check also
fails on a class the vendored spec does not declare yet. Your commit
is safe here — the next sync will not overwrite it; it fails instead,
naming this pull request — but every later sync for this spec stays
paused until this pull request is merged (which deletes the branch,
so the following sync starts fresh), or closed and its branch
deleted.