Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds Video Edit widget guides in English, Japanese, Korean, and Chinese. The guides document trim and crop controls, preview and loading behavior, workflow values, troubleshooting, and related node references. The guides are added to the matching Interface Guide navigation lists. ChangesVideo Edit documentation
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This PR adds localized documentation and navigation without changing video-processing behavior. No concrete defect is established; the final-frame wording remains unverified against the frontend implementation. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 5 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
98fbee6 to
1b8c75c
Compare
1b8c75c to
1be4ad4
Compare
Summary
Adds
interface/features/video-edit.mdx(EN + zh/ja/ko) for the interactive Video Edit widget that ComfyUI renders inside the Trim Video (Advanced) (VideoTrim) and Crop Video (VideoCrop) nodes, and registers it in the Interface Guide navigation for all four languages.The built-in node reference pages describe the node parameters only (
start_time/durationfor trim,x/y/width/heightfor crop). The widget itself (filmstrip with start/end frame handles, crop box over the preview, playback row, metadata rows) had no documentation anywhere.Fact sources
ComfyUI_frontendsrc/components/videoEdit/(WidgetVideoEdit.vue,VideoEditPanel.vue,VideoFilmstripTrim.vue,VideoCropOverlay.vue) for the controls, the empty state, and the metadata rows.ComfyUI_frontendsrc/composables/video/useVideoEditModel.tsfor how the start/end frame handles map tostart_timeplusduration, and the duration 0 behavior when the end handle sits on the last frame.ComfyUI_frontendsrc/locales/{en,zh,ja,ko}/{main.json,nodeDefs.json}for the localized node display names, the category label, and the field labels used on the page.ComfyUI_frontendsrc/renderer/extensions/vueNodes/widgets/registry/widgetRegistry.tsfor the widget registration (the editor is a modern node design / Nodes 2.0 widget, so the page links the Nodes 2.0 setting).ComfyUIcomfy_extras/nodes_video.py(VideoTrim,VideoCrop) andcomfy_api/latest/_io.py(VIDEO_EDITio type) for the node side of the widget.Scope and checks
docs.jsonnav entry once per language (inserted through the canonical location and re-generated withbun .github/scripts/snippets/gen-code-pages.tsso the code-pages freshness check stays green).pnpm translate -- interface/features/video-edit.mdx --no-openapi, then the zh/ja/ko node names, field labels, and category terms were corrected by hand against the frontend locale files, andpnpm translate:sync-hashrefreshed the hashes.essentials_categorybackend field), the preview starts unmuted (the mute button silences it), and the ratio list sits below the preview.images/yet. Both nodes render it inline in the node body, so a screenshot would need a running graph.check-anchors.pypasses on all four files,structure-parityreports no failures, no em dashes, 5 H2 sections in each language, no leading pipes.cc @lin-bot23