fix(linear-ticket): ignore post-close signal runs - #260
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughChangesCompleted pull request handling
Merge Risk: ⚪ Minimal · up to Validation now treats an exact-head pull request that completed before the workflow run as a successful no-op, avoiding stale result publication while retaining fail-closed behavior for ambiguous or missing associations. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Addresses #260 (comment) and the associated exact-head review round.
Summary
workflow_runvalidator starts as a completed no-oppull_requestspayloadWhy
A signal run can finish after its PR merges. GitHub then supplies an empty
workflow_run.pull_requestslist; the commit association still identifies the now-closed exact-head PR. Requiring one open PR makes the privileged validator fail after the gate has already completed.Verification
python3 -m unittest discover -s scripts/linear-ticket/tests -p 'test_*.py' -v(75 tests)python3 -m py_compile scripts/linear-ticket/validate.py scripts/linear-ticket/tests/test_validate.pygit diff --check