Skip to content

fix(challenges): point Challenges 10-11 at the student's own Learning Room repo - #239

Merged
accesswatch merged 1 commit into
mainfrom
fix/challenge-10-11-golden-path
Jul 4, 2026
Merged

fix(challenges): point Challenges 10-11 at the student's own Learning Room repo#239
accesswatch merged 1 commit into
mainfrom
fix/challenge-10-11-golden-path

Conversation

@accesswatch

@accesswatch accesswatch commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Second instance of the missing-dependency pattern behind support#58: Challenge 10 told students to clone vscode-sci-fi-themes (students have no write access, so Step 5 push fails) and its CLI option cloned Community-Access/learning-room.git, which does not exist. Challenge 11 sent students to the sci-fi themes repo to open their Day 2 PR, but the Day 2 autograders only run on PRs inside the student's own learning room.

Both challenge templates and the CHALLENGES.md hub now use the student's own Learning Room repository, matching the canonical practice flow already documented in Chapter 14. Chapter 14's read-only sci-fi clone examples are unchanged.

Changes

  • learning-room/.github/ISSUE_TEMPLATE/challenge-10-go-local.yml and challenge-11-day2-pr.yml: clone/PR target is now the student's own room, with green-Code-button guidance; CLI example fixed; stuck-table row updated.
  • .github/ISSUE_TEMPLATE/ legacy copies synced.
  • docs/CHALLENGES.md: hub summaries updated; work.md and html/ regenerated.

Tests

  • npm run test:automation: 87 pass
  • npm run validate:authoritative-sources: pass

Generated with Claude Code

GitHub Workshop Bot @claude
fix(challenges): point Challenges 10-11 at the student's own Learning…
445f263 
… Room repo

Challenge 10 told students to clone vscode-sci-fi-themes (no student
write access, so the push step fails) and its CLI option cloned
Community-Access/learning-room.git, which does not exist. Challenge 11
sent students to the sci-fi themes repository to open their Day 2 PR,
but the Day 2 autograders (local-commit, day2-pr) only run on pull
requests inside the student's own learning room.

Both challenges and the CHALLENGES.md hub now use the student's own
Learning Room repository, matching the canonical practice flow in
Chapter 14 (which already said to clone your own room and explicitly
warned against cloning anything else). Chapter 14's read-only sci-fi
clone examples are unchanged. Legacy .github/ISSUE_TEMPLATE copies kept
in sync; work.md and html/ regenerated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@accesswatch
accesswatch requested a review from taylorarndt as a code owner July 4, 2026 17:01
Copilot AI review requested due to automatic review settings July 4, 2026 17:01
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Learning Room Validation Report

Great work. Your changes look good.

Resources

@accesswatch
accesswatch merged commit dfd8c53 into main Jul 4, 2026
11 checks passed
@accesswatch
accesswatch deleted the fix/challenge-10-11-golden-path branch July 4, 2026 17:01
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Hi! I am Gandalf, your workshop agent. I bring a little magic to make this interaction clear, helpful, and fun. Here is my review of your pull request:

Report Status

Validation Needs Attention [ACTION REQUIRED]

Required Checks

  • Issue Reference
    PR should reference the issue it addresses (e.g., "Closes #12")
    Add "Closes #XX" to your PR description to automatically close the issue when merged. Learn more: docs/04-working-with-issues.md

  • PR Description

  • File Location
    Changes should be in learning-room/ directory only
    Student contributions should modify files in learning-room/docs/ only. Other directories are workshop infrastructure.

Learning Resources

Based on your changes, these guides might help:

Automated validation by Learning Room Bot. Gandalf generated this review. Last updated: 2026-07-04T17:01:44.106Z
Questions? Check PR Guidelines or mention @Facilitator

@github-actions github-actions Bot added documentation Improvements or additions to documentation needs-work labels Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Peer Review Assigned

Hi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review.

For @taylorarndt:

This is a great opportunity to practice code review skills! Here's what to look for:

Content Quality:

  • Does the change accomplish what the issue describes?
  • Is the writing clear and helpful?
  • Are there any typos or grammar issues?

Accessibility:

  • Proper heading hierarchy (H1 → H2 → H3, no skips)?
  • Descriptive link text (not "click here")?
  • Alt text on images?
  • [TODO] markers removed?

Documentation:

  • Code blocks are properly formatted?
  • Tables have headers?
  • References/links work correctly?

Review Guidelines:

  • Be kind and constructive
  • Suggest improvements, don't just point out problems
  • Ask questions if something is unclear
  • Approve when ready or request changes with explanation

Resources:

Pairing by Learning Room Grouping Engine

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Progress Update

Great work, @accesswatch!

Current Level: Explorer
Merged PRs: 29
Next Level: Contributor (NaN more merged PRs)

Available Challenges:

  • 01 Scavenger Hunt
  • 02 First Issue
  • 03 Join Conversation

Keep going!

Copilot AI reviewed Jul 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Day 2 challenge instructions so learners clone and open PRs against their own Learning Room repository (where they have write access and where autograders run), instead of the read-only sci-fi themes repo.

Changes:

  • Re-targets Challenge 10/11 templates to the student’s Learning Room repo and updates the related “stuck” guidance.
  • Updates the Challenge Hub summaries to match the new practice flow.
  • Regenerates published artifacts (work.md, html/, search index) to reflect the updated templates/docs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
work.md Regenerated workbook content reflecting updated Day 2 challenge instructions.
learning-room/.github/ISSUE_TEMPLATE/challenge-10-go-local.yml Updates Challenge 10 to clone/push to the student’s Learning Room repo.
learning-room/.github/ISSUE_TEMPLATE/challenge-11-day2-pr.yml Updates Challenge 11 to open the PR in the student’s Learning Room repo.
.github/ISSUE_TEMPLATE/challenge-10-go-local.yml Syncs the legacy Challenge 10 issue template copy.
.github/ISSUE_TEMPLATE/challenge-11-day2-pr.yml Syncs the legacy Challenge 11 issue template copy.
docs/CHALLENGES.md Updates Challenge Hub Day 2 summaries and steps to point at the Learning Room repo.
html/work.html Regenerated published HTML for work.md.
html/docs/CHALLENGES.html Regenerated published HTML for the Challenge Hub.
html/search-index.json Regenerated search index to reflect updated docs ordering/content.

Comment thread learning-room/.github/ISSUE_TEMPLATE/challenge-10-go-local.yml
**What you will do:** Clone the sci-fi themes repo to your computer, create a feature branch, make an edit to the README.md file, commit locally, and push to GitHub.
**What you will do:** Clone your own Learning Room repository (this repo) to your computer, create a feature branch, make an edit to the README.md file, commit locally, and push to GitHub.

**Your repository URL:** On this repository's main page, select the green **Code** button and copy the HTTPS URL. It looks like `https://github.com/Community-Access/learning-room-...-YOUR-USERNAME.git`. You already have write access to this repo, so your push will work without any extra setup.
Comment thread learning-room/.github/ISSUE_TEMPLATE/challenge-10-go-local.yml
Comment on lines +103 to +105
# Step 1: Clone (paste your Learning Room URL from the green Code button)
git clone https://github.com/Community-Access/learning-room-...-YOUR-USERNAME.git
cd learning-room-...-YOUR-USERNAME
Comment thread .github/ISSUE_TEMPLATE/challenge-10-go-local.yml
**What you will do:** Clone the sci-fi themes repo to your computer, create a feature branch, make an edit to the README.md file, commit locally, and push to GitHub.
**What you will do:** Clone your own Learning Room repository (this repo) to your computer, create a feature branch, make an edit to the README.md file, commit locally, and push to GitHub.

**Your repository URL:** On this repository's main page, select the green **Code** button and copy the HTTPS URL. It looks like `https://github.com/Community-Access/learning-room-...-YOUR-USERNAME.git`. You already have write access to this repo, so your push will work without any extra setup.
Comment thread .github/ISSUE_TEMPLATE/challenge-10-go-local.yml
Comment on lines +103 to +105
# Step 1: Clone (paste your Learning Room URL from the green Code button)
git clone https://github.com/Community-Access/learning-room-...-YOUR-USERNAME.git
cd learning-room-...-YOUR-USERNAME
Comment thread html/work.html
1. Open GitHub Desktop
2. Choose File &gt; Clone Repository
3. Paste the URL: `https://github.com/Community-Access/vscode-sci-fi-themes.git`
3. Paste your Learning Room repository URL (copied from the green **Code** button on this repo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@taylorarndt taylorarndt Awaiting requested review from taylorarndt taylorarndt is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation needs-work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@accesswatch