Skip to content

fix(autograder): never grade seeded workshop issues as Challenge 2 submissions - #243

Merged
accesswatch merged 1 commit into
mainfrom
fix/autograder-skip-seeded-issues
Jul 4, 2026
Merged

accesswatch merged 1 commit into
mainfrom
fix/autograder-skip-seeded-issues

Conversation

@accesswatch

Copy link
Copy Markdown
Collaborator

The Challenge 2 issue-filed autograder only guarded on author == actor,
so peer simulation issues seeded with a user token (and any future
App-token seeding, which also triggers workflows) got flagged with
challenge-2-needs-revision labels and a Needs revision comment. Skip
issues titled Peer Simulation:, Challenge, or Start Here: - those are
workshop artifacts, not student submissions. The mislabels and comments
this caused in the 8 cohort rooms have been cleaned up in place.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

…bmissions

The Challenge 2 issue-filed autograder only guarded on author == actor,
so peer simulation issues seeded with a user token (and any future
App-token seeding, which also triggers workflows) got flagged with
challenge-2-needs-revision labels and a Needs revision comment. Skip
issues titled Peer Simulation:, Challenge, or Start Here: - those are
workshop artifacts, not student submissions. The mislabels and comments
this caused in the 8 cohort rooms have been cleaned up in place.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@accesswatch
accesswatch requested a review from taylorarndt as a code owner July 4, 2026 17:34
Copilot AI review requested due to automatic review settings July 4, 2026 17:34
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Learning Room Validation Report

Great work. Your changes look good.

Resources

@accesswatch
accesswatch merged commit fac80cb into main Jul 4, 2026
9 checks passed
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Hi! I am Gandalf, your workshop agent. I bring a little magic to make this interaction clear, helpful, and fun. Here is my review of your pull request:

Report Status

Validation Needs Attention [ACTION REQUIRED]

Required Checks

  • Issue Reference
    PR should reference the issue it addresses (e.g., "Closes #12")
    Add "Closes #XX" to your PR description to automatically close the issue when merged. Learn more: docs/04-working-with-issues.md

  • PR Description

  • File Location

Learning Resources

Based on your changes, these guides might help:


Automated validation by Learning Room Bot. Gandalf generated this review. Last updated: 2026-07-04T17:34:31.350Z
Questions? Check PR Guidelines or mention @Facilitator

@github-actions github-actions Bot added documentation Improvements or additions to documentation needs-work labels Jul 4, 2026
@accesswatch
accesswatch deleted the fix/autograder-skip-seeded-issues branch July 4, 2026 17:34
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Peer Review Assigned

Hi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review.

For @taylorarndt:

This is a great opportunity to practice code review skills! Here's what to look for:

Content Quality:

  • Does the change accomplish what the issue describes?
  • Is the writing clear and helpful?
  • Are there any typos or grammar issues?

Accessibility:

  • Proper heading hierarchy (H1 → H2 → H3, no skips)?
  • Descriptive link text (not "click here")?
  • Alt text on images?
  • [TODO] markers removed?

Documentation:

  • Code blocks are properly formatted?
  • Tables have headers?
  • References/links work correctly?

Review Guidelines:

  • Be kind and constructive
  • Suggest improvements, don't just point out problems
  • Ask questions if something is unclear
  • Approve when ready or request changes with explanation

Resources:


Pairing by Learning Room Grouping Engine

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Progress Update

Great work, @accesswatch!

Current Level: Explorer
Merged PRs: 29
Next Level: Contributor (NaN more merged PRs)

Available Challenges:

  • 01 Scavenger Hunt
  • 02 First Issue
  • 03 Join Conversation

Keep going!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Learning Room Challenge 2 “issue filed” autograder workflow to avoid treating seeded workshop artifacts (peer simulations, challenge tracker issues, and onboarding roadmap issues) as student Challenge 2 submissions.

Changes:

  • Expands the job-level if: guard to additionally skip issues whose titles start with Peer Simulation:, Challenge , or Start Here:.
  • Reflows the conditional into a folded multi-line expression for readability and future maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants