check_drivesize: fix volume discovery when volume is not mounted to a letter. - #441
Draft
inqrphl wants to merge 2 commits into
Draft
check_drivesize: fix volume discovery when volume is not mounted to a letter.#441inqrphl wants to merge 2 commits into
inqrphl wants to merge 2 commits into
Conversation
inqrphl
marked this pull request as draft
August 5, 2026 10:22
inqrphl
commented
Aug 5, 2026
inqrphl
left a comment
inqrphl
left a comment
Contributor
Author
There was a problem hiding this comment.
i will test it on a windows machine using multiple scenarios when I have time, do not merge yet
inqrphl
force-pushed
the
check-drivesize-volume-discovery-custom-path-fix
branch
2 times, most recently
from
August 6, 2026 11:45
e204696 to
3c6a8f8
Compare
Contributor
Author
|
seems to be working locally, but want to add #442 alike tests before marking it ready. we had way too many problems with volumes, caused by every small change to check_drivesize the tests will be added to check_drivesize unit tests, not end to end tests |
… letter. if mount is not mounted to a drive letter and to a folder like "C:\mounttest" its "name" attribute is set. "drive" attribute is empty. fill them according to the folder path organize the attributes nicely in the custom path decivder working on volumes, building up attributes like drive_or_id , drive_or_name , drive_or_name_or_id add _matching_volume_path attribute, this is used when folder= attrbitue is set and it picks a volume in its parent path as its matching volume. folders are added with their attributes 'id' and 'drive' set to their custom paths. matching volume path is lost, unless we save it to '_matching_volume_path' attribute '_matching_volume_path' is then used in the setDeviceInfo call rename the testPath as volumeTestPath for clarity, it is tested against volumes. it starts off from cleanedPath so no need to clean it again. additionally, improve some comments
matched volume might have its drive as empty string, if it is a volume mounted to a folder
inqrphl
force-pushed
the
check-drivesize-volume-discovery-custom-path-fix
branch
from
August 6, 2026 16:12
862a966 to
793b39c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if mount is not mounted to a drive letter, its "name" attribute is set. "drive" attribute is empty. use it instead when checking for prefixes against searched custom path
rename the testPath as volumeTestPath for clarity, it is tested against volumes. it starts off from cleanedPath so no need to clean it again.
additionally, improve some comments