fix(console): simplify broken-link resolution - #129
Merged
Conversation
Signed-off-by: John Siracusa <siracusa5@users.noreply.github.com>
Signed-off-by: John Siracusa <siracusa5@users.noreply.github.com>
Signed-off-by: John Siracusa <siracusa5@users.noreply.github.com>
siracusa5
force-pushed
the
codex/smart-conflict-resolution
branch
from
August 11, 2026 20:45
27c2234 to
8ed8e9a
Compare
siracusa5
added a commit
that referenced
this pull request
Aug 11, 2026
main moved ahead by four PRs while this branch was open. Three of them interacted with it directly: #131 added packages/core/tests/sidecar-state.test.mjs to the test chain. The only conflict was package.json's "test" script — this branch replaced the chain with scripts/test.mjs, so a mechanical "keep ours" would have silently dropped that suite from the gate. It is registered now, and the runner grew assertEverySuiteRegistered(): on a full run it walks packages/core/tests and scripts/tests and refuses to start if a test file exists that no suite names. The old chain had the same failure mode and no way to notice it. #132 removed two stray NUL bytes from service.mjs and main.mjs — the actual cause of the grep blindness this branch had documented in CONTRIBUTING as a locale problem. That diagnosis was wrong: a NUL byte makes grep treat a file as binary regardless of LANG, and both files now grep cleanly with LANG unset. The section is corrected to name the real cause, and scripts/test.mjs gained assertNoNulBytes() so a reintroduced NUL fails the gate instead of quietly hiding a file from every search. #132 fixed the instances; nothing stopped the next one. #130/#129 touched console and desktop only and merged clean. Also aligns packages/core/package.json's node floor with the root's new >=22. Verified after the merge: npm test 33/33; console typecheck + 453 tests; desktop 106 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: John Siracusa <siracusa5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes broken-link discrepancies understandable and safely actionable without forcing users through impossible answer-selection controls. The default path is now a candid one-click acknowledgement, while direct repair, evidence, alternate reasons, and priority remain available when needed.
Changes
target_missingacknowledgement and direct source-concept repair pathTest Plan
npm testnpm --prefix apps/console test— 429 testsnpm --prefix apps/console run typechecknpm --prefix apps/console run buildnpm --prefix apps/site run build— 39 pagesNotes