docs(scheduler): describe the pre-review refresh hold; correct the discarded-check figures - #1940
seonghobae wants to merge 1 commit into
Conversation
…scarded-check figures docs/org-required-workflow-rollout.md described only the post-approval update-branch posture; the pre-review refresh (now held while current-head checks are in flight, #1937) is stated next to it. CHANGELOG's "22/28" and "21/30" counted phantom check-runs created and cancelled in the same instant; the evidence actually discarded per push was 10 and 11. Refs #1935 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
2026-09-20 protected-base admission correction for GitHub reports this Ready PR mechanically non-mergeable. Exact comparison with protected Moving it to Draft / Proposed preserves every commit, valid delta, review, and thread. This is not closure or abandonment. Reconcile protected main through an ordinary non-force merge, repair valid findings, run terminal exact-head protection, and obtain qualifying independent current-head approval before returning to Ready. No review dismissal, synthetic status, manual rerun, bypass, Force Push, merge, or Close is authorized. |
Docs-only follow-up to #1937 (refs #1935). No workflow, script, or test changes.
What changes
docs/org-required-workflow-rollout.md, "Automation boundary" bullet: it described only the post-approvalupdate-branchposture. One sentence now states the pre-review refresh next to it — an unapprovedBEHINDPR is refreshed before review dispatch so the review sees the current base, but only when no current-head check run is still queued or running; otherwise the scheduler decideswait(the fix(scheduler): hold pre-review branch updates while current-head checks are in flight #1937 guard). This is the same correction fix(scheduler): hold pre-review branch updates while current-head checks are in flight #1937 made toCLAUDE.md, applied to the rollout record. The bullet is not pinned by any contract test (git grepovertests/for its phrases is empty).CHANGELOG.md: a correction bullet under the fix(scheduler): hold pre-review branch updates while current-head checks are in flight #1937 entry. Its "22/28" and "21/30" counted every check-run cancelled at the push; check-runs for jobs behindneeds:are created and cancelled in the same instant (phantoms), so the evidence actually discarded per push was 10 (fix(codeql): serialise the dispatched scan matrix with toJSON #1926) and 11 (Wire test_opencode_fact_gate_contract.sh into CI #1484). The mechanism and the fix are unchanged; only the magnitude was overstated (~2×). Measured by a peer session withstarted_at < push, recorded on Scheduler pre-review update-branch discards in-flight checks under queue saturation: 76/77 merges since 09-04 had 0/12 required contexts at merge time #1935.Verification
Full gate on this head with
GITHUB_ACTIONS=true: 2896 passed / 1 skipped,coverage report --fail-under=100→ 100%,interrogate→ 100%; the 27 doc-contract tests (test_pr_governance_audit_contract.pyand the rollout/changelog contracts) pass.Not claimed
mainand verified in production (0update_branchdecisions in the first 10 post-merge runs, queue 616 → 509).strict=true, the dispatch-actor variable (CodeQL dispatch terminal status publication remains unproven across repositories #1929) and the sidecar account-cap lever (fix(strix): coalesce push scans per protected branch instead of one group per run id #1938 thread) are separate lanes.🤖 Generated with Claude Code