fix(review): pin sidecar to 429-recovering gateway - #2366
seonghobae wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CO owner handoff for exact |
![cwl-noema-review[bot]](https://avatars.githubusercontent.com/u/295022177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Noema LLM review
The PR correctly updates the contextual-orchestrator pin to SHA b1352648d2f23278cb12c7a1768c20fae2d6c5f1 across the ADR, the provisioning script, and the contract tests. This coordinated update ensures consistent runtime behavior and prevents CI failures. The CHANGELOG accurately documents the purpose of the pin (429 recovery) and the specific dependency constraints.
Reviewed changed lines
docs/adr/0003-contextual-orchestrator-vendored-free-zdr.md:27 (RIGHT): The SHAb1352648d2f23278cb12c7a1768c20fae2d6c5f1is consistently updated and matches the implementation inscripts/ci/contextual_orchestrator_review_sidecar.sh(line 17) andtests/test_contextual_orchestrator_review_sidecar_contract.py(line 43), falsifying the hypothesis of a version mismatch.scripts/ci/contextual_orchestrator_review_sidecar.sh:17 (RIGHT): The pin update is synchronized with the contract test attests/test_contextual_orchestrator_review_sidecar_contract.py(line 43), ensuring that the CI gate will validate the exact SHAb1352648d2f23278cb12c7a1768c20fae2d6c5f1.tests/test_contextual_orchestrator_review_sidecar_contract.py:43 (RIGHT): The contract test'sORCH_PIN_SHAmatches the implementation inscripts/ci/contextual_orchestrator_review_sidecar.sh(line 17), confirming the intended version lock.CHANGELOG.md:1 (RIGHT): The entry accurately describes the pin advance tob1352648and aligns with the PR goal of implementing 429 recovery/cooldown.
Adversarial validation
scripts/ci/contextual_orchestrator_review_sidecar.sh:17 (RIGHT)falsified: The pin update is inconsistent with the contract test, causing CI failure. — Both files contain identical SHAb1352648d2f23278cb12c7a1768c20fae2d6c5f1.docs/adr/0003-contextual-orchestrator-vendored-free-zdr.md:27 (RIGHT)falsified: The ADR documents a different SHA than the one deployed in the shell script. — Both locations specifyb1352648d2f23278cb12c7a1768c20fae2d6c5f1.- Residual risk: none
Findings
- No blocking findings.
- Result: APPROVE
- Head SHA:
e76ed33aea995bac415933c87b47e827125f48b8 - Reviewer credential:
noema-review-github-app-refresh - Actor:
cwl-noema-review[bot]
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head product diff. Coverage is a separate gate.
Changed files
CHANGELOG.md— repository behaviordocs/adr/0003-contextual-orchestrator-vendored-free-zdr.md— operator or user guidancescripts/ci/contextual_orchestrator_review_sidecar.sh— review and security gate shell pathtests/test_contextual_orchestrator_review_sidecar_contract.py— regression suite
Changed behavior
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: CHANGELOG.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: CHANGELOG.md"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: 0003-contextual-orchestrator-vendored-free-zdr.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: 0003-contextual-orchestrator-vendored-free-zdr.md"]
R2 --> V2["docs review"]
Evidence --> S3["CI script: contextual_orchestrator_review_sidecar.sh"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: contextual_orchestrator_review_sidecar.sh"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test: test_contextual_orchestrator_review_sidecar_contract.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_contextual_orchestrator_review_sidecar_contract.py"]
R4 --> V4["targeted test run"]
Findings
No source-backed product finding is synthesized from the coverage gate. A coverage miss belongs in the status comment.
- Head SHA:
e76ed33aea995bac415933c87b47e827125f48b8 - Workflow run: 36181624701
- Workflow attempt: 1
- Coverage gate:
failure
Review outcome
Coverage is a gate, not the review. This body reviews the changed product files.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Repository file: CHANGELOG.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Repository file: CHANGELOG.md"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: 0003-contextual-orchestrator-vendored-free-zdr.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: 0003-contextual-orchestrator-vendored-free-zdr.md"]
R2 --> V2["docs review"]
Evidence --> S3["CI script: contextual_orchestrator_review_sidecar.sh"]
S3 --> I3["review and security gate shell path"]
I3 --> R3["Review risk: CI script: contextual_orchestrator_review_sidecar.sh"]
R3 --> V3["bash -n plus Strix self-test"]
Evidence --> S4["Test: test_contextual_orchestrator_review_sidecar_contract.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_contextual_orchestrator_review_sidecar_contract.py"]
R4 --> V4["targeted test run"]
OpenCode Review Overview
Coverage evidence did not pass, so approval is blocked. The formal pull-request review is the source-backed diff review, not this status comment. |
This branch has not been deployed
1 participant
Cause
The central OpenCode, Noema, and Strix sidecar still vendors contextual-orchestrator at protected
main@767e67f, before the gateway's bounded provider-429 failover and cooldown recovery landed. Noema job 106510155855 ended with HTTP 429 after one caller request and 1506 seconds; its log does not identify the internal gateway stage that exhausted the pool. Ordinaryorchestrator/freerouting can end review without the recovery already present in gateway source. Noema's structured-synthesis path has a separate 429-storm defect under repair in ContextualWisdomLab/contextual-orchestrator#1220; this pin alone does not fix that path.Change
Pin the sidecar to protected
main@b1352648, the newest first-parent main revision I found that includes the 429 recovery (529c5f6fis an ancestor) while retaining a hash-bound releasedfast-mlsirmdependency. Keep the exact-SHA checkout, free/ZDR policy, provider credential scope, and one gateway request per consumer job. Gatewaymain@5665b0adis not pin-compatible yet: its VCSfast-mlsirmentry fails the sidecar'spip --require-hashesinstall. ContextualWisdomLab/contextual-orchestrator#995 is the separate packaging repair.Verification
tests/test_rate_limit_aware_admission.pyatb1352648: 23 passed (one pre-existing pytest config warning in the reused isolated interpreter).bash -nandgit diff --check: pass.Hosted review requests and exact-head required checks are pending; local tests do not establish a Noema, OpenCode, or Strix approval. The structured-synthesis repair must land and be included in a later sidecar pin before that particular Noema 429 path is fixed in the central runner.