feat(reports): leftover-map explained leftover share on pair segments (v2.30.0) - #802
seonghobae wants to merge 27 commits into
Conversation
Name leftover-map coordinates ξ_{1:2} and ζ_{1:2} on leftover
post–criterion pairs (ADR 0267, migration 0245). After make seed,
closest and farthest leftover pairs sit above the member list with
ξ (x, y) ζ (x, y) next to leftover-map distance d; click opens that
post. Rank-0 unused axes store 0.0. When coordinates, reconstruction,
and distance are finite, R̂ = ξ · ζ and d = ‖ξ − ζ‖. Never invent a
leftover score. Never invent a theta.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping
unobserved item–respondent interactions: A latent space item response
model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with
application to principal component analysis. Biometrika, 58(3), 453–467.
* feat(reports): leftover-map graphic display (v2.25.0) Draw persisted leftover-map coordinates ξ and ζ as a Gabriel biplot above leftover pair buttons (ADR 0268). Click a post marker to open that post. Omit the plot when coordinates are missing. No new columns. Never invent a leftover score or a theta. * fix(reports): preserve leftover-map distances Signed-off-by: Codex <codex@localhost> * fix(reports): keep plot labels readable Signed-off-by: Codex <codex@localhost> * docs(reports): correct leftover plot omission rule --------- Signed-off-by: Codex <codex@localhost> Co-authored-by: Codex <codex@localhost>
…787) Caption leftover-map plot axes with persisted ADR 0148 leftover-map axis share σ_k² / Σ_j σ_j² (ADR 0269). Rank-0 zero-share axes still name 0%. A missing or non-finite share omits that axis badge and keeps the existing leftover-map axis text. Click a post marker to open that post. No new columns. Never invent a leftover score or a theta.
Signed-off-by: Codex <codex@localhost>
Caption leftover-map graphic-display axes with persisted leftover-map coordinate ticks (ADR 0270). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, and axis ticks that match ξ (x, y) ζ (x, y) on the pair row; click a post marker or a pair button opens that post. Origin is always named 0. Rank-0 unused axes do not invent −1 / +1 drawing-scale ticks. Never invent a leftover score or a theta. No new columns.
Caption leftover-map graphic-display pair segments with persisted leftover-map distance d (ADR 0271). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, axis ticks that match ξ (x, y) ζ (x, y) on the pair row, and pair segments that match d on the pair row; click a post marker or a pair button opens that post. A missing or non-finite d omits that segment caption. Do not invent d from plotted coordinates. Never invent a leftover score or a theta. No new columns.
Caption leftover-map graphic-display pair segments with persisted leftover-map reconstruction R̂ (ADR 0272). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, axis ticks that match ξ (x, y) ζ (x, y) on the pair row, pair segments that match d on the pair row, and pair segments that match R̂ on the pair row; click a post marker or a pair button opens that post. A missing or non-finite R̂ omits that reconstruction caption. Do not invent R̂ from plotted coordinates. Never invent a leftover score or a theta. No new columns.
… (v2.30.0) Caption leftover-map graphic-display pair segments with persisted leftover-map explained leftover share e = R̂²/R² (ADR 0273). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, axis ticks that match ξ (x, y) ζ (x, y) on the pair row, pair segments that match d on the pair row, pair segments that match R̂ on the pair row, and pair segments that match R̂²/R² on the pair row; click a post marker or a pair button opens that post. A missing or non-finite e omits that explained leftover share caption. A share greater than 1 is shown, never clamped. Do not invent e from R̂ and R or from plotted coordinates. Never invent a leftover score or a theta. No new columns.
📝 WalkthroughWalkthrough잔여 맵 쌍 세그먼트가 지속된 재구성값 Changes잔여 맵 세그먼트 캡션
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PairData
participant layoutLeftoverMapPlot
participant LeftoverMapPlot
participant i18n
PairData->>layoutLeftoverMapPlot: 지속된 R̂와 e 전달
layoutLeftoverMapPlot->>layoutLeftoverMapPlot: 캡션 포맷과 위치 계산
layoutLeftoverMapPlot->>LeftoverMapPlot: 캡션 텍스트와 좌표 전달
LeftoverMapPlot->>i18n: 캡션 레이블 번역 조회
i18n-->>LeftoverMapPlot: 번역된 접근성 레이블 반환
Merge Risk: 🔵 Low · up to The leftover-map now adds reconstruction and explained-share captions, but very short custom plot heights can place the caption stack outside the visible SVG area. This is a bounded presentation issue and should be addressed before relying on compact plot sizing. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 10 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Write probe after open. Stacked onto leftover-map coordinates ( |
|
#803 leftover-map unexplained leftover share |
Signed-off-by: Codex <codex@localhost>
seonghobae
left a comment
There was a problem hiding this comment.
검증 결과 finding은 유효합니다. 현재 height=20, captionCount=3이면 maximumLabelY = -8이 되어 labelY가 top inset 12 아래로 내려갑니다. 기존 정상 크기에서의 12px stack 간격은 유지하되, 고정 inset 사이에 3개 caption을 모두 넣을 수 없는 짧은 canvas에서는 stack 간격만 가용 높이에 맞춰 축소하는 쪽으로 RED→최소 수리를 진행합니다. 좌표/leftover 값 자체는 변경하지 않습니다.
seonghobae
left a comment
There was a problem hiding this comment.
추가 ancestry finding을 확인했습니다. PR metadata의 base는 main@83eba561…지만 commit graph compare는 아직 merge base가 0f1d447…이고 behind_by=7입니다. 실제 branch tree도 protected #931의 Tests/PROV-O/Ontology Pages admission contract와 tests/test_tests_workflow_contract.py를 포함하지 않습니다. 따라서 현재 queued runs는 current protected workflow contract의 exact-head evidence로 볼 수 없습니다. 네 protected blob을 그대로 채택한 뒤 protected main을 추가 parent로 하는 non-force convergence commit으로 ancestry를 수렴시키고, 그 새 head에서만 검증을 다시 봅니다.
Adopt the four protected workflow/admission contract blobs exactly, then record protected main as the second parent without rewriting the reviewed product tree.
Promote the verified clean convergence tree from staging onto unchanged #811 and exact #802. Preserve #811 v2.37 successor i18n/layout/runtime authority, retain the verified Vietnamese terminology repair, and adopt the current #802 product-gap baseline. Temporary workflow history is absent. This is a non-force two-parent convergence.
seonghobae
left a comment
There was a problem hiding this comment.
Fresh owner-state correction: the CodeQL allowlist premise in this PR body is now stale. .github#1927 records post-change execution evidence that github-actions[bot],opencode-agent[bot] is live and admits the App sender; authorization is repaired. That does not make this head merge-ready: .github#1902 is still Draft with an unresolved exact-job wake race, and .github#810 remains open because the authoritative dependency-graph comparison still returns 403 for public non-fork canaries. Preserve this exact leaf head and existing source GREEN; do not retrigger by no-op commit, weaken Security, or transfer sibling scanner results. Current gates remain central CodeQL recovery, authoritative Dependency Review availability, and qualifying independent exact-head approval.
Pull request was converted to draft
Summary
R̂and explained leftover sharee = R̂² / R²(ADR 0272–0273 / v2.29.0–v2.30.0).R̂,e, theta, scores, inner products, cosine, or lengths from plotted coordinates.Protected-base state
Protected
mainremains83eba56149eb802cd63642c507c324c9976ec78e. Exact #802 head is32f1cda10a2a1a6cabd64a3ae6f59bd6f0b20fd6, open / Draft / mechanically mergeable. Validation admission has already completed; terminal required owner gates and independent approval remain unsatisfied. Review5120320187, RED35aa0ab86cb25ee80c6e6a94be3cd917967d6178, and repair85b3233e203eb4f45460a0856a8f02fb02fdc4ccpreserve bounded caption placement on a 20px canvas. The later protected-main/workflow convergence did not rewrite ADR 0272–0273 product semantics.Exact-head gates
33953039688: success33953039546: success33953039536: success33953039573: success33953039614: failure only at central Dependency Review support preflight (101302890109); Scorecard/Trivy/OSV succeeded but are not substitutes33953039547: fail-closed without an accepted authenticated terminal current-head receiptThe canonical
.githubowner path remains responsible for Dependency Review support and terminal CodeQL publication/receipt behavior. Do not churn this leaf head, synthesize status, copy a reusable workflow locally, or weaken the required gates merely to obtain a different receipt.Descendant authority
#811 no longer has an unresolved structural divergence from this foundation. Its Vietnamese terminology repair was promoted first, then exact #802 was joined into #811 by verified clean two-parent product commit
e0fad9af9d8fe446769474bd5fc8300c902a052f; compare from this #802 head is therefore behind0. #812 was subsequently reconstructed non-force on current #811 asaea06ad7c70f4542a1413b6003d414c0c42d59a7. #813 remains the next Draft descendant under active current-parent reconstruction. No descendant checks, reviews, or release evidence transfer to this Draft parent.Repository validation on this exact head is useful source/test evidence only. Normal merge remains unavailable until required owner receipts are terminal GREEN, qualifying independent approval exists, and applicable authenticated PostgreSQL API, browser/a11y, k6/performance, and release evidence are current. Synthetic fixtures remain regression evidence only.
Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.
Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.