Skip to content

docs(prd): reconcile occupational authority identities - #847

Merged
seonghobae merged 11 commits into
codex/gap-baseline-exact-head-20260921from
fix/prd-authority-unique-ids-20260831
Sep 21, 2026
Merged

seonghobae merged 11 commits into
codex/gap-baseline-exact-head-20260921from
fix/prd-authority-unique-ids-20260831

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Closes #807 only when the composed occupational delta ultimately reaches protected main; this stack-base merge is not protected delivery.

Reconciles duplicated occupational PRD identifiers against protected-main ADR authority. Unsupported full SOC/content-model/linkage claims remain explicitly unavailable; Voice ADR 0256 stays distinct from occupational authority. Adds fail-closed documentation regressions for unique PRD identifiers and resolvable direct ADR references.

Single-writer succession — 2026-09-21

Fresh review found that #847 and #1123 had diverged from protected main@83eba56149eb802cd63642c507c324c9976ec78e while both writing docs/product-technical-gap-baseline.md and tests/test_documentation_hygiene.py. The #847 baseline overlay was stale: it named predecessor 9bb4f07a..., called this PR Draft after it was Ready, and exposed only a first-page PR lower bound instead of #1123's audited timestamp/cutoff snapshot.

The branch was therefore reconstructed by ordinary two-parent/non-force convergence at cd77fab8b623ff71c3fb71f22205ce4cff3d2cb3, preserving the occupational ADR/PRD delta and all valid hygiene tests while taking #1123 4023ac2b... as the gap-snapshot authority. Fresh compare had exact merge-base 4023ac2b..., behind_by=0; the child-only delta was exactly three files: ADR 0245, docs/product-requirements.md, and the semantically combined documentation-hygiene test. docs/product-technical-gap-baseline.md was no longer a child-only delta.

This PR had pre-existing squash auto-merge armed. After retargeting to codex/gap-baseline-exact-head-20260921, GitHub normally squash-merged the three-file child delta into that non-default parent at 1eb8f5f56c2b9038c937f6a428f83278e4e08700. The merge is valid stack composition, not protected-main delivery and not release evidence. It transferred no predecessor check receipt or approval. Exact successor #1123 now contains every valid #847 source/test delta together with its own queue-snapshot contract, so there is no second writer to reopen or duplicate.

All pre-existing #847 review threads were resolved before succession, and there were no open PRs directly based on the #847 branch. Current protected delivery authority is therefore #1123 exact successor, not this closed PR. #1123 must obtain fresh exact-head required checks and qualifying independent approval before any protected integration.

No self-approval, admin bypass, force push, destructive rebase, gate weakening, stale receipt transfer, no-op wake commit, or release was used.

@seonghobae
seonghobae enabled auto-merge (squash) August 30, 2026 20:17
@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f2f848d0-7741-46d1-bf03-d1f0266bddc7

📥 Commits

Reviewing files that changed from the base of the PR and between b6b1d62 and 889b9b7.

📒 Files selected for processing (2)
  • docs/product-technical-gap-baseline.md
  • tests/test_documentation_hygiene.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

PRD의 직업 분류 범위를 승인된 자료로 제한했습니다. FJA I/O-Psychology 계층과 ADR 추적성을 갱신했습니다. ADR 참조, PRD 식별자, 현재 ADR의 역참조를 검증하는 문서 위생 검사를 추가했습니다.

Changes

PRD 권위 및 문서 검증

Layer / File(s) Summary
직업 분류 요구사항 재정의
docs/product-requirements.md
PRD-FR-2L은 23개 SOC 주요 그룹과 4개 ONET 직무 영역으로 범위를 제한합니다. 미승인 SOC 세부 단계와 ONET Content Model은 사용할 수 없음으로 명시합니다. PRD-FR-2B에서 O*NET 연결 테이블을 제거하고, PRD-FR-2C에 FJA I/O-Psychology 의미 계층을 추가했습니다.
ADR 추적성과 기준 문서 갱신
docs/product-requirements.md, docs/product-technical-gap-baseline.md
ADR 0256을 지식 그래프·온톨로지·출처 추적성 목록에 추가했습니다. 제품 권위 레지스터의 저장소 이름을 ContextualWisdomLab/disksage로 변경했습니다. 2026-09-21 및 2026-08-31 기준 블록을 추가했습니다.
문서 위생 회귀 검사
tests/test_documentation_hygiene.py
ADR 목록과 범위를 커서 기반으로 파싱합니다. 잘못된 부분 번호, 잘못된 범위 끝점, 내림차순 범위를 거부합니다. ADR 참조의 존재 여부, PRD 식별자 고유성, 현재 ADR의 PRD 역추적성을 검증합니다.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other · Severity of issue fixed: Medium

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #807의 코딩 요구사항을 충족합니다. docs/product-requirements.md는 중복 식별자를 PRD-FR-2L, PRD-FR-2B, PRD-FR-2C로 분리하고, 지원되지 않는 SOC 세부 수준·O*NET Content Model·연계 테이블·review UI를 unavailable로 유지합니다. Voice ADR…
Out of Scope Changes check ✅ Passed 변경 범위는 Issue #807의 문서 권위 정합성, 식별자·ADR 참조 회귀 검사, 관련 기준선 증거에 한정됩니다. docs/product-technical-gap-baseline.md의 exact-head 및 권위 등록부 보강은 요구사항의 inventory와 문서 위생을 지원합니다. 소스 레코드, 자격 증명, API, 스키마, 모델, 릴리스 변경은 …
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 1 files. (1 skipped: 1…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 중복된 PRD 식별자와 ADR 권위 정보를 조정하는 주요 변경 사항을 정확히 요약합니다. 간결하고 변경 범위와 관련성이 분명합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge August 30, 2026 21:33
@seonghobae
seonghobae enabled auto-merge (squash) August 30, 2026 21:34
@opencode-agent
opencode-agent Bot disabled auto-merge August 31, 2026 06:17
@seonghobae
seonghobae enabled auto-merge (squash) August 31, 2026 09:28
@opencode-agent
opencode-agent Bot disabled auto-merge August 31, 2026 14:54
@seonghobae
seonghobae enabled auto-merge (squash) August 31, 2026 15:33
@opencode-agent
opencode-agent Bot disabled auto-merge August 31, 2026 16:26
@seonghobae
seonghobae enabled auto-merge (squash) August 31, 2026 16:41
@opencode-agent
opencode-agent Bot disabled auto-merge September 1, 2026 00:48
@seonghobae
seonghobae enabled auto-merge (squash) September 1, 2026 00:54
Align the ecosystem authority register with the protected remote name and add a documentation hygiene regression without promoting an unmerged local PRD.

Signed-off-by: Codex <codex@localhost>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head audit found and fixed one remaining authority identity drift in 0b1dc95: the product authority register now preserves the protected remote canonical name ContextualWisdomLab/disksage, while retaining the protected-main design document because docs/PRD.md is not present on disksage main. A documentation-hygiene regression locks the canonical spelling. Focused result: 10 passed; Ruff passed. No unmerged local PRD was promoted.

coderabbitai[bot]

This comment was marked as resolved.

Signed-off-by: Codex <codex@localhost>
devin-ai-integration[bot]

This comment was marked as resolved.

@opencode-agent
opencode-agent Bot disabled auto-merge September 1, 2026 08:44
Adopt protected main #923's docs-only Tests workflow delta while preserving the occupational PRD/ADR identity repair unchanged.
@seonghobae
seonghobae marked this pull request as draft September 3, 2026 04:57

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh ancestry/live-authority finding: current head is ed11f7e44e54dac68c97e62cd89fcd101e2cfd90, not the stale a2295720... recorded in the body, and protected main@83eba56149eb802cd63642c507c324c9976ec78e is seven commits ahead of this branch's merge base 0f1d44726cc8fd9fd05a4f9b91ec40ff6be8802d. The protected-only delta is exactly the three repository-local Draft-admission workflows plus tests/test_tests_workflow_contract.py; it does not overlap this PR's occupational PRD/ADR/documentation-hygiene delta. Preserve all four valid documentation/test files and non-force converge the current protected workflow contract. Do not transfer predecessor gates/reviews or close the surviving authority repair.

@seonghobae
seonghobae marked this pull request as ready for review September 21, 2026 02:40
@seonghobae
seonghobae enabled auto-merge (squash) September 21, 2026 02:40
@seonghobae
seonghobae changed the base branch from main to codex/gap-baseline-exact-head-20260921 September 21, 2026 05:59
@seonghobae
seonghobae merged commit 1eb8f5f into codex/gap-baseline-exact-head-20260921 Sep 21, 2026
5 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation priority: medium status: draft type: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(prd): reconcile duplicated occupational requirements and ADR identities

1 participant