docs(talent): select candidate-document disposition and worker-record retention boundary - #306
docs(talent): select candidate-document disposition and worker-record retention boundary#306seonghobae wants to merge 1 commit into
Conversation
…, and worker-record retention
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.
Findings
1. HIGH Current-head GitHub Checks - Fix failed required checks before approval
- Problem: Failed same-head checks remain for
ddd76f85dc8063327a2c35d6bdf3e7a13181000d. - Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
- Fix: Read and fix the failed check logs below, then rerun the current-head checks.
- Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.
Failed checks:
- Required Noema Review/noema-review: FAILURE (https://github.com/ContextualWisdomLab/Orgmetra/actions/runs/34582476704/job/103209324457)
- noema-review check run: failure (https://github.com/ContextualWisdomLab/Orgmetra/actions/runs/34582476704/job/103209324457)
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: 0303-candidate-document-lifecycle-disposition.md (2 files)"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: 0303-candidate-document-lifecycle-disposition.md (2 files)"]
R1 --> V1["docs review"]
OpenCode Review Overview
|
|
Downstream implementation finding for ADR 0303: #307 currently implements only the transport/validation packet in Python. Under the repository language boundary, the ADR/TRD follow-up should record why this is an allowed validation-boundary use rather than policy/compute ownership, and an explicit removal/escalation condition: if candidate-document lifecycle evaluation becomes a material hot path, performs batch policy computation, cryptographic erasure orchestration, or other performance/security core work, move that compute to the Rust-first owner and keep Python as a thin validated transport boundary. Do not imply that the Python packet owns document_records execution or high-impact employment decisions. I am leaving #306 source unchanged here to avoid competing with its existing exact-head review lane; this is a repair requirement for the canonical documentation writer before/with downstream implementation acceptance. |
|
ADR 0303 consumer audit found a concrete owner prerequisite now tracked as #308. #307 can currently express completed destruction states, but protected |
|
Exact-head gate RCA for
No leaf source mutation, paid/provider override, manual rerun, or synthetic approval is warranted. Keep the current exact head unchanged; ordinary merge remains blocked until a qualifying exact-head independent review clears the request. |
Selects the product/domain boundary requested by #303.
What
Adds the ADR slice (#303 deliverable 1) plus its cited reference note:
docs/adr/0303-candidate-document-lifecycle-disposition.md— Context Map splitting four obligations: (1) non-selected applicant return/interim storage/destruction, (2) talent-pool enrollment as a separate purpose with its own lawful basis and expiry, (3) minimum materialization of accepted-candidate material into the worker/employment record, (4) post-separation statutory retention of the worker register and contract records.docs/doctoring/candidate-document-lifecycle-references.md— cited Korean authority (채용절차법 제3조·제11조 and 시행령 제2·3·4조; PIPA 제15·18·21조; 근로기준법 제42조 and 시행령 제22조) and the applied boundary.Key decisions
talent_acquisition(candidate/recruitment truth),people_core(worker/employment truth),document_records(artifact lifecycle). No cross-service application-table SQL.Scope of this PR
Documentation only (no source, no
manifest.json, nodocs/adr/README.md). This is the ADR slice; PRD/TRD/DATA_MODEL/package code and policy execution remain follow-up work.Exact-head authority
develop@eb9757f8649aaad026a9865508d9aad50c1a7a4fddd76f85dc8063327a2c35d6bdf3e7a13181000d34582476741: SUCCESS; Repository quality103209013400is exact-head GREEN34582476764: SUCCESS; documentation-only scope is contract-valid34582476771: SUCCESS for the documentation-only scope; dependency-review/OSV/Trivy/Scorecard/gitleaks are scope-valid skipped and are not misrepresented as scans of executable dependency changes34582476748: SUCCESS; Python and Actions compatibility consumers are current-head GREEN, with the dispatch producer correctly skipped for this documentation-only scope34582476704, job103209324457: FAILURE in central model/provider availability, not an Orgmetra documentation finding. Exact-head admission, reviewer credential selection, repository-scoped App token, live-head validation, visibility resolution, and CO sidecar provisioning succeeded.Prepare Noema model verdictfailed, publication was skipped, and the retainednoema-sidecar-evidenceartifact is id10192644325, digestsha256:a00883245b2f3eebe8330e7134ab7d995777c832e26f88a01f600e6b90a80850. Artifact inspection shows free-pool degradation (24candidates,16probed, only2ready against target8, with 429/404/timeout pressure) followed by a gateway/provider-connectivity 502. Canonical central handoff:ContextualWisdomLab/.github#1948comment5632815766.103209668226is current-head FAILURE only because the same-head Noema check was failed; its formalCHANGES_REQUESTEDreview reports no semantic source finding and explicitly points to Noema as the failed peer check.The two documentation files have deterministic current-head repository/CodeQL evidence and no verified semantic source finding. Do not churn this leaf branch to manufacture model availability. Normal merge remains fail-closed while the central Noema/OpenCode review governance is non-passing; no self/model approval, provider/model pin, paid fallback, no-op retrigger, predecessor verdict transfer, administrator bypass, force-push, or destructive rebase.
Refs #303.