feat(operability): add People API health and readiness probes - #74
Draft
seonghobae wants to merge 18 commits into
Draft
feat(operability): add People API health and readiness probes#74seonghobae wants to merge 18 commits into
seonghobae wants to merge 18 commits into
Conversation
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 22, 2026 03:28
seonghobae
marked this pull request as draft
August 22, 2026 04:07
seonghobae
marked this pull request as ready for review
August 22, 2026 04:11
seonghobae
marked this pull request as draft
August 22, 2026 04:14
seonghobae
marked this pull request as ready for review
August 22, 2026 04:17
Contributor
Author
|
@opencode-agent Please review the current unchanged head against protected |
seonghobae
marked this pull request as draft
September 6, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible operability boundary
Protected
develop@9e3e4847510e1e612b48474ba42b177b8ed824dfhas customer-facing People read/write/hire ASGI boundaries; this PR adds executable process liveness and owned-PostgreSQL readiness without folding Keyverse or any other dedicated-writer dependency into Orgmetra process health.GET /healthis dependency-free process liveness.GET /readychecks only the People API's owned PostgreSQL dependency through a read-only constantSELECT 1. Dependency failures are normalized to bounded503evidence without copying database exceptions, credentials, tenant identifiers, or HR values into customer-facing responses. Synchronous DB-API readiness work is executed away from the ASGI event loop while the complete connection-factory/connection/cursor/transaction/SELECT 1call remains on one worker thread.RED → root-cause repairs
fdd66c4f3386bf446bb520342a6b44efc0bf8024proved the operability module was absent; root implementation831de2302ccce6836870edc294afca2e572fe72caddedPeopleOperabilityAsgiApp,ReadinessProbe, andPostgresReadinessProbe.ccd736da14aa185f81b6b26b8eac56850a6605dc→ repairec49aec82fff1439fe13f16dbbabb08069f5ffca; deterministic manifest/provenance was then refreshed rather than weakening validation.7a860810be754d3ee0f89ae62803c43ed31ebdd4added mapping-row coverage → root repairf27420b89af4e4681b84d6d2e7f5289ab7c7e170removed tuple-shape coupling while retaining fail-closed no-row behavior.82c8ef9597e878d09812ba64c66beb0c0438aa7amade the stale tuple-only documentation contract fail in People API run33183729417/ job98891216600; the traceability contract was corrected and the addressed Devin thread resolved.303133ec656a95ac397ca459e17631862e42e5a5ran People API Quality33192924170/ job98922704282and failed because/readyinvoked the synchronous readiness probe on the event loop. Root repairac7b947a15838453576d5d3f10c3bcd2ecde4da1offloaded the complete probe usingasyncio.to_thread. The regression was strengthened to a blocking synchronous probe that can complete only if an event-loop callback remains schedulable. The addressed Devin event-loop thread is resolved.Exact-current-head evidence
Current exact head:
7d75e683b5bca2881f70e4447e69b3de80babd00.Fresh live base:
develop@9e3e4847510e1e612b48474ba42b177b8ed824df.GitHub reports the PR open · non-draft · mergeable. Mergeability is not merge authorization.
Orgmetra-owned and target-local exact-head evidence is terminal GREEN, including:
33193114176/ job98923374415— exact checkout, 157 tests passed, 1,456 statements / 468 branches at exact 100% coverage, clean checkout33193114155331931142063319311417233193114187coverage-source-treejob98923423916— terminal successcoverage-evidencejob98923583444— terminal success98923349106— terminal success with an actual same-head review runThe required OpenCode verifier is terminal failure on run
33193113714/ job98923735602: exact-head and coverage validation complete, but the Reviews API contains no authenticatedopencode-agent/opencode-agent[bot]APPROVEDorCHANGES_REQUESTEDverdict for7d75e683…. This is not an Orgmetra source/coverage defect. The exact-head RED/remedy/GREEN canary is routed through the existing dedicated owner pathContextualWisdomLab/.github#624; no target-side shim or foreign mutation was introduced.Required Strix run
33193113727/ job98923347998is terminal FAILURE on this same exact head. Trusted central source.github@e1b03eebc6dc5c85aed393e5928927c96376cf46, exact target/base materialization, workflow smoke, secret gating, contextual-orchestrator sidecar provisioning, and pinned Strix installation all succeeded. The first causal boundary is central route/provider handling:orchestrator/freeadmitted video/avatar/non-chat routes (alibaba/wan-3.0-prime,inclusionai/ling-3.0-flash-fin:free,alibaba/wan-3.0,heygen/avatar-iv) for a text/code security-review workload; sidecar evidence also recorded an earlier413 request_too_large. Strix then made three bounded attempts and each failed before any authoritative vulnerability report with HTTP 500internal_error/LLM CONNECTION FAILED(request IDse18c27492ebf41469118953a9c351f3f,0f29d14178f24c7cad86fdb66f705198,8fae693e7af64aed905100efd1b11488). The job correctly failed closed asSTRIX_PROVIDER_UNAVAILABLE; artifact9694995275, SHA-256af2a2167b5cdb0d81c30c946e2c9156c574059b5103082b46210e5287136b457, is diagnostic-only and not passing security evidence. The exact canary, first causal boundary, smallest owner remedy, and unchanged-head GREEN acceptance are routed through existing owner issueContextualWisdomLab/.github#1327. No Orgmetra route override, status shim, gate weakening, or foreign source/ref/workflow/settings mutation was introduced.Review state
The previously unresolved Devin event-loop observation is repaired test-first, answered with exact RED/GREEN evidence, and resolved. Fresh Devin review reports 0 new potential issues and all current inline threads are resolved. There is still no qualifying independent non-author
APPROVEDreview, so approval policy is not satisfied.Scope discipline
This branch does not mutate Keyverse, Naruon, contextual-orchestrator, central
.github, or another dedicated-writer repository, and introduces no cross-service application-table SQL. Metrics, network-policy/Kubernetes manifests, startup-probe tuning, release provenance, release/version/tag work remain separate slices and are not claimed here.Merge governance
This PR is not merge-ready while OpenCode or Strix is non-passing, or qualifying independent approval is absent. Immediately before any future merge, refetch exact head/base/reviews/threads/rules/checks and use expected-head protection. Do not self-approve, use administrator bypass, weaken a gate, manufacture evidence, or transfer predecessor checks/reviews.