docs: separate buyer gap decisions from evidence history - #309
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review for 187310346c5c42b22e53f734c2c9ce7122df0d7f finds one remaining code-currentness defect plus one PR-state mismatch. The navigation split itself is sound and same-head native CI 34350606647 completed success before the state correction, but the new live surface says 129 open pull requests / 12 Ready / 117 Draft. Fresh complete GitHub search after #309 exists returns 130 open PRs, and after restoring this PR to Draft the split is 12 Ready / 118 Draft. Because the file is explicitly titled Current exact observation, #309's own creation/state transition makes that observation immediately stale rather than merely historical. Repair by binding the snapshot to an explicit observed-at cut that includes #309, or by otherwise making the self-reference semantics explicit; do not silently retain 129 as current truth. Separately, the PR body says Keep this PR Draft but the live PR was Ready; I restored Draft without changing head/base/source. The Draft-transition CI 34351493514 is skipped and is not new GREEN. No approval or merge-ready claim.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head follow-up for 1ca68892dcfa708a99a429dd66e4061841dc3244: review 5154249954's self-staleness finding is source-repaired. Test-first 32b01eb... rejects a continuously-current queue heading and requires a dated, self-inclusive observation receipt; 84340f2... applies the minimal buyer-surface repair; 1ca6889... aligns traceability. Repository-native CI 34354999220 completed success on this exact head: Python repository contracts, canonical formatting, locked workspace tests, strict Clippy, rustdoc, and exact production coverage all passed. The PR was returned to Draft immediately afterwards; transition runs are skipped and do not add GREEN evidence. This is not an approval or merge-ready claim. #238 adoption, independent/countable review where applicable, required central workflows, protected-main integration, and release evidence remain separate gates.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head review on 1ca68892dcfa708a99a429dd66e4061841dc3244 finds a new documentation-contract isolation defect after the navigation split. The live buyer surface is now correctly a dated receipt, but the compatibility loader redirects only module.BASELINE to the archived dossier. The preserved legacy modules still bind mutable current companions: legacy_documentation_active_pr_evidence_contract.py reads current CHANGELOG.md, DOCUMENTATION_FITNESS.md, and active-PR maturity; legacy_gap_snapshot_inventory_consistency.py reads current CHANGELOG.md; legacy_live_gap_evidence_integrity_contract.py reads current CHANGELOG.md, AGENTS.md, and scripts/ci/collect_live_merge_evidence.sh. This is already observable on the same head: the archived September-9 contracts expect the historical 131 open / 14 Ready / 117 Draft changelog receipt, while the new buyer surface records the later 12:57 UTC self-inclusive 130 / 12 / 118 receipt. Simply updating the current changelog to the new cut would therefore make the supposedly historical compatibility tests fail on a valid current documentation update. Preserve the byte-identical legacy modules, but isolate every historical input they consume (or split the still-current operational assertions into dedicated current contracts) so archived evidence tests no longer pin mutable current documents/scripts. Then make the live changelog/current decision surface use an unambiguous dated receipt rather than two differently scoped 'current' inventory claims. Do not weaken/delete the historical assertions. This is a COMMENT finding, not approval or merge readiness.
|
Writer lease ACTIVE — exact |
|
OriginWeave Browser Session owner-path update for the canonical product-gap surface: #317 is now exact Keep the current Browser Session state accurate rather than promoting active-PR code to shipped behavior: production still has the uncited 4096-byte |
|
Fresh live-state repair finding on #309 itself: the PR is currently non-Draft at head |
|
Fresh single-writer handoff from the benchmark lane: #324 is now the active #323 implementation for the Unicode 18.0.0 |
|
Follow-up for the compact product-gap baseline owner lane: the #323/#324 handoff needs one provenance qualifier before adoption. On 2026-09-15 KST, Unicode's versioned When #309 next currentizes |
|
The earlier live-state finding on this owner lane can now be narrowed: current head remains The PR body is still stale because it labels |
37fcd57
into
docs/refresh-live-gap-baseline-2026-08-28
Finding
#238 comment
5598004000identified a buyer-navigation defect that remained after #307 merged into the documentation branch:docs/product-technical-gap-baseline.mdwas still 186,500 bytes and mixed the current delivery decision surface with many dated implementation checkpoints before the buyer gap view.Exact-head review
5154249954then found a second correctness defect on187310346c5c42b22e53f734c2c9ce7122df0d7f: the compact surface called a static queue snapshotCurrent exact observationand recorded 129 open PRs before #309 itself existed. Creating #309 and restoring it to Draft changed the queue to 130 open PRs / 12 Ready / 118 Draft. A static Markdown snapshot cannot remain continuously current, especially when the documentation PR itself changes the observed queue.Test-first lineage
Predecessor is exact #238 branch head
16098a0eecc57bfc545d22ce632d95d1ffccfe67.83a91b6d50f6f43c4ab030ef2e47a77f20106244requires the canonical baseline to stay at or below 220 lines / 24,000 UTF-8 bytes, place## Buyer gap matrixwithin the first 90 lines, keep datedPrevious verified cutprose out of the live surface, and preserve the extracted dossier. On the predecessor this is source-semantic RED: the archive path did not exist and the baseline was 186,500 bytes. No hosted RED is claimed before PR publication.39dd06d5ba5fde1331f328add44e16c22c53887freuses the exact predecessor baseline Git blobc4a87e6c70f2c48b6e4ef820f18e8ddb0dca5696atdocs/evidence/product-technical-gap-baseline-through-2026-09-09.mdrather than rewriting historical evidence.32b01ebda4ce061e63c926434d4320847c93fbcfrequires an explicit observed-at receipt, rejects the continuously-current heading, requires the cut to include this docs: separate buyer gap decisions from evidence history #309 successor in the 130 / 12 / 118 split, and requires explicit live-state supersession after the cut. On predecessor187310346...this is source-semantic RED; no hosted RED is claimed.84340f2ac35ddbc0571038418acc93e0f9882595changes only the bounded buyer surface:## Observed delivery cut — 2026-09-09 12:57 UTC, self-inclusive queue counts, and an explicit statement that later live GitHub state supersedes the receipt.1ca68892dcfa708a99a429dd66e4061841dc3244records the problem, constraints, rejected continuously-live alternative, decision, risks, exact RED/fix lineage and acceptance contract.5155412458then exposed historical-contract coupling: archived compatibility tests still read mutable current companions. The seven ordinary successor commits from1ca68892...through current6c4187f0849fb0ff89087c0a47eaef4666345ec0preserve the compact/live versus archived-evidence split, add the historical changelog companion, rebind the historical loader, tighten current/archive inventory receipt tests, and correct predecessor wording without changing production/runtime or.github/**authority. Compare is 7 ahead / 0 behind from1ca68892....Observation receipt
The 2026-09-09 12:57 UTC cut records 130 open PRs (12 Ready/non-draft, 118 Draft), 14 open non-PR issues, protected
main@87c4daa1830bac5a5228b6036752ad5633232085, active ruleset18156473, and an empty GitHub Release inventory. Those counts are a dated receipt, not a live dashboard; later GitHub state supersedes them.The matrix keeps the then-current high-value causal gaps visible near the top. Later owner comments and live GitHub state supersede individual active-PR heads or queue counts; active-PR evidence must not be promoted to protected-main truth merely because it is named in this dated decision surface.
Current exact-head verification
Current exact head is
6c4187f0849fb0ff89087c0a47eaef4666345ec0on exact base16098a0eecc57bfc545d22ce632d95d1ffccfe67. GitHub currently reports the PR open / Ready / mergeable. Ready is a verification/queue state only; it is not direct protected-main merge authority and does not bypass the required #238 parent adoption path.Repository-native CI
34365887571completed success on this unchanged exact head.102514364056received a GitHub-hosted runner and passed Python repository contracts, canonical formatting, workspace tests, strict Clippy, and API documentation.102514364737received a GitHub-hosted runner and passed production function/line/region/branch measurement, diagnostics publication, and exact coverage enforcement.34365638568isskipped; it is not additional GREEN evidence.This supersedes the stale body claim that
1ca68892...was the current head and that the PR was Draft. The current exact-head repository GREEN still does not satisfy parent adoption into #238, independent/countable review where required, current central required workflows, protected-main integration, browser acceptance, or release evidence.Ownership and acceptance
This remains a documentation/test-only successor stacked on #238. The effective changed-file set is limited to
CHANGELOG.md, the compact/archived product-gap evidence and traceability documents, historical/current documentation contract loaders, and documentation regression tests. It does not touch production browser/runtime source,.github/**, workflows, rulesets, secrets, sandboxing, trial counts, another owner branch, protected main, release/tag state, or approval state.Do not merge this PR directly to protected main. Normal adoption into #238 comes first, followed by #238's own current-head verification and governance. No active-PR source result, protocol ACK, advisory review, or clean repository CI alone is protected-main/browser/release acceptance.