feat(psychometric): restore Driver p.16 discreteDIFFUSIONstd Q_Δt/p on main - #311
Draft
seonghobae wants to merge 1 commit into
Draft
feat(psychometric): restore Driver p.16 discreteDIFFUSIONstd Q_Δt/p on main#311seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
…n main Port the scalar Q_Δt / p map onto current main after 0ce16e8 dropped the pre-consolidation code. Form strictly positive asymDIFFUSION first. Refuse unstandardised Q_Δt, continuous q/p = −2a, and trait-contaminated Q_Δt/(trait+p+added). 2017-era summary.ctsemFit.R does not form a discreteDIFFUSIONstd matrix. Not Kalman, not matrix expm, not DSEM.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
commented
Aug 30, 2026
seonghobae
left a comment
Contributor
Author
There was a problem hiding this comment.
Requesting Copilot review of discreteDIFFUSIONstd Q_Δt/p restore.
Contributor
Author
|
@github-copilot review this exact head c73b250. Requesting Copilot code review of the discreteDIFFUSIONstd restore. |
This was referenced Aug 30, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores Driver, Oud, and Voelkle (2017, p. 16) scalar
discreteDIFFUSIONstdQ_Δt / ponto current main after0ce16e8dropped the pre-consolidation code while research notes already named the map (register items 57–58).Ports the #296 slice onto
6444a81. Does not cherry-pick the conflicting #296 commits.Form strictly positive
asymDIFFUSIONp = −q / (2 a)first, thenQ_Δtfrom Equation 4, then the ratio. Scalar stationary identity is1 − exp(2 a Δt). The 2017-erasummary.ctsemFit.Rforms unstandardiseddiscreteDIFFUSIONwhenverbose=TRUEand does not form adiscreteDIFFUSIONstdmatrix. Printed p. 16 example isdiscreteDRIFTstd. Footnote 4 uses only the relevant within-subject variance.Fail-closed: zero
q,a ≥ 0, non-event clock, non-positiveΔt.Refuse: unstandardised
Q_Δt, continuousq/p = −2 a(DIFFUSIONstd), trait-contaminatedQ_Δt / (trait + p + added).Supersedes conflicting #296. Does not invent
DIFFUSIONstd(register 59). Does not convert #310.Local
cargo test -p psychometric_coreis green. Meredith (1993) and Mislevy (1991) remain unread (Unpaywallis_oa: false). Still not a Kalman filter, not a matrixexpm, not ESEM estimation, not DSEM, and not ctsem estimation.Head is
c73b250. Do not merge without independent APPROVE and green product CI. Stays Draft.