Skip to content

fix(psychometric): cover MANIFESTVARstd Display claim-boundary arms - #353

Draft
seonghobae wants to merge 2 commits into
mainfrom
agent/psychometric-manifestvarstd-display-arms
Draft

fix(psychometric): cover MANIFESTVARstd Display claim-boundary arms#353
seonghobae wants to merge 2 commits into
mainfrom
agent/psychometric-manifestvarstd-display-arms

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Recovery tests already constructed the four Driver p. 16 MANIFESTVARstd claim-boundary errors (θ = 0, unstandardised θ, MANIFESTTRAITVARstd, Equation 5 Var(y)) but never executed Display. Nightly unique-line coverage on #351 listed error.rs 1227/1230/1233/1236. This PR only runs those match arms.

Not a new map. Not stacked on #351 / #350 / #310. Meredith (1993) and Mislevy (1991) remain unread (Unpaywall 2026-08-31T06:36Z: is_oa: false). Still not a Kalman filter, not a matrix expm, not ESEM estimation, not DSEM, and not ctsem estimation.

Head is b460d42101e30a7ca55a54f17951ffdfc4349677 on main 1bc02f580cf48e1d39da239f0e818453437c31c3.

Verification

  • cargo fmt -p psychometric_core -- crates/psychometric_core/src/error.rs
  • cargo test -p psychometric_core --lib standardised_manifest_variance_boundary_messages_are_stable
  • cargo clippy -p psychometric_core --all-targets -- -D warnings

Do not self-approve. Do not merge without independent non-author APPROVE + exact-head required-check success.


Devin Review

Recovery tests constructed the four p.16 MANIFESTVARstd refusals but
never executed Display. Nightly unique-line coverage listed those
match arms. This is not a new map.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cwl-noema-review cwl-noema-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noema LLM review

The PR introduces several changes to the psychometric core, including the recovery of standardised manifest-trait variance, and the test cases for standardised manifest variance boundary messages have been updated to be more comprehensive and robust.

Findings

  • [low] crates/psychometric_core/src/error.rs:2073: The code could benefit from additional comments to explain the purpose of the test cases and the expected behavior of the code.

  • Result: APPROVE

  • Head SHA: b460d42101e30a7ca55a54f17951ffdfc4349677

  • Reviewer credential: noema-review-github-app

  • Actor: cwl-noema-review[bot]

@seonghobae
seonghobae marked this pull request as draft August 31, 2026 07:03
Resolve the CHANGELOG.md append conflict by keeping both entries.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Restack on protected main (a243f18)

Non-force merge of origin/main (merge commit 05f882d6); the only conflict was the CHANGELOG.md append, both entries kept.

Local evidence on the pushed head (toolchain 1.98.0): cargo test -p psychometric_core 363 passed / 0 failed, clippy -D warnings clean, cargo fmt --all --check clean, documentation/workspace/docstring contracts PASS, git diff --check clean.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant