fix(psychometric): cover MANIFESTVARstd Display claim-boundary arms - #353
fix(psychometric): cover MANIFESTVARstd Display claim-boundary arms#353seonghobae wants to merge 2 commits into
Conversation
Recovery tests constructed the four p.16 MANIFESTVARstd refusals but never executed Display. Nightly unique-line coverage listed those match arms. This is not a new map.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Noema LLM review
The PR introduces several changes to the psychometric core, including the recovery of standardised manifest-trait variance, and the test cases for standardised manifest variance boundary messages have been updated to be more comprehensive and robust.
Findings
-
[low] crates/psychometric_core/src/error.rs:2073: The code could benefit from additional comments to explain the purpose of the test cases and the expected behavior of the code.
-
Result: APPROVE
-
Head SHA:
b460d42101e30a7ca55a54f17951ffdfc4349677 -
Reviewer credential:
noema-review-github-app -
Actor:
cwl-noema-review[bot]
Resolve the CHANGELOG.md append conflict by keeping both entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Restack on protected main (a243f18)Non-force merge of Local evidence on the pushed head (toolchain 1.98.0): 🤖 Generated with Claude Code |
Summary
Recovery tests already constructed the four Driver p. 16
MANIFESTVARstdclaim-boundary errors (θ = 0, unstandardisedθ,MANIFESTTRAITVARstd, Equation 5Var(y)) but never executedDisplay. Nightly unique-line coverage on #351 listederror.rs1227/1230/1233/1236. This PR only runs those match arms.Not a new map. Not stacked on #351 / #350 / #310. Meredith (1993) and Mislevy (1991) remain unread (Unpaywall 2026-08-31T06:36Z:
is_oa: false). Still not a Kalman filter, not a matrixexpm, not ESEM estimation, not DSEM, and not ctsem estimation.Head is
b460d42101e30a7ca55a54f17951ffdfc4349677on main1bc02f580cf48e1d39da239f0e818453437c31c3.Verification
cargo fmt -p psychometric_core -- crates/psychometric_core/src/error.rscargo test -p psychometric_core --lib standardised_manifest_variance_boundary_messages_are_stablecargo clippy -p psychometric_core --all-targets -- -D warningsDo not self-approve. Do not merge without independent non-author APPROVE + exact-head required-check success.