feat(analysis): bind posterior topic-context producer to an analysis-run profile - #432
seonghobae wants to merge 15 commits into
Conversation
…run profile GAP-004 leftover / ADR 0068. Bind existing TopicContextPosteriorArtifact to cutoff-safe topic_context_posterior_v1. Posterior coordinates are not importance; missing draws are not collapsed; lineage events stay producer-supplied.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Author COMMENT on exact head 4ab92f3. This is not APPROVE. Independent = non-author, non-bot APPROVE. Two independent current-head APPROVEs required before merge. ADR 0068. Do not self-approve.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ab92f3f2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesPosterior topic-context 실행 프로필
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant analysis_engine
participant SnapshotManifest
participant TopicContextPosteriorArtifact
participant TerminalResult
Operator->>analysis_engine: topic_context_posterior_v1 실행 요청
analysis_engine->>SnapshotManifest: snapshot, cutoff, source digest, availability 검증
analysis_engine->>TopicContextPosteriorArtifact: producer contract와 artifact digest 검증
analysis_engine->>TerminalResult: 검증된 좌표 수와 digest-bound summary 생성
analysis_engine-->>Operator: 성공 또는 fail-closed 오류 반환
Suggested reviewers: Merge Risk: 🔵 Low · up to This PR adds a public execution path that can produce a succeeded analysis result from caller-supplied run, manifest, and artifact data after consistency checks. If exposed beyond a trusted integration boundary, an unauthorized caller could provide internally consistent but non-authoritative inputs; the production adapter should enforce authorization and authoritative storage before relying on this path. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 3 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hour-35 exact-head review request. Current head @opencode-agent review |
|
Hour-36 re-verify: topic-context posterior head 3e09ff2. Zero independent APPROVEs. Do not duplicate. Exact-head Checks on 3e09ff2 only. Do not self-approve. @opencode-agent review. |
seonghobae
added
enhancement
ChatGPT Codex Connector
Resolve the CHANGELOG.md append conflict by keeping both entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Restack on protected main (a243f18)Non-force merge of Local evidence on the pushed head (toolchain 1.98.0): 🤖 Generated with Claude Code |
1 participant
Summary
GAP-004 / ADR 0068 Draft fold child. Binds the existing protected-main
TopicContextPosteriorArtifactproducer contract totopic_context_posterior_v1without reimplementing TRSL-TM fitting.Current exact head is
021843391c8b450e728703e4ec721b2f4a5b3927on protectedmain@a243f18da4a4ca8a8d068c39922537f1f8ed6ad0. Compared with #41603f8de2e..., this child is diverged from the same protected-main merge base with 15 unique child commits and 81 commits on the surviving vehicle side. It remains Draft and is not an independent landing candidate.Repair lineage
b44f8bc5c88504b6cc3b1f3631bc406aa44fd23a: equivalent RFC 3339 cutoff instants and terminal validation/inference separation.6f3eae7627825a5d04da0371c321ef9639c3ea8f, warning cleanup1bf55d91c5274954d5062fff64b13aa1f0be769f: compare cutoffs by instant, keep persisted artifact/manifest cutoffs canonical, and report terminal validation asvalidatedwhile retainingposterior_topic_coordinates_not_importanceon the artifact.91407b566764519ce83ca3609c1b98d30f6fdc42: boundedfrom_json/to_json, unknown-field refusal, canonical timestamp validation, round-trip tests.0042422275bd3725e7e1ca9cb92e885a0ff0e8ce: an authoritative manifest must carry independent availability for supporting evidence resources rather than deriving it from document availability.ae867a95bb1ac525b014cf78224fcde0fa862438: exact-set bind everyevidence_resource_idactually used by lineage events, document relations, and memberships tosupport_evidence_available_at; missing, substituted, malformed, or post-cutoff support fails closed. The executor does not subtract late support from an already-fitted posterior.875a8224...,8dcd00bf...,c9c3e36740a44fbb1c71df6ee68a31313d103625: manifest wire refusal, temporal fixture migration, and execution regressions for future/missing/substituted support evidence.3b6de91d.../021843391...: ADR 0068 remainsProposedand documents the exact-set support-evidence admission boundary.The approved producer contract is enforced exactly: artifacts whose
model_contract_versionis nottrsl-tm-v1fail closed.AnalysisResultSummary.validation_statusremains provider validation status; the artifact owns the scientific inference boundary.Current gate
The previous late-support leakage finding is repaired and all inline review threads are resolved. There is still no qualifying current-head approval. Exact-head Rust Foundation, Documentation Quality, Security Scan, Semgrep, and CodeQL receipts for
021843391...are queued/pending; predecessor receipts do not transfer.The child PR itself is currently mergeable against protected main, but it is deliberately retained as a fold child because it is independently diverged from #416. Use an ordinary non-force conflict-resolving fold into the surviving Analysis Run vehicle rather than landing this branch separately. Do not Close #432 until #416 or another verified successor has inherited the source, tests, ADR/doctoring, manifest wire contract, instant cutoff semantics, exact-set document/support availability, producer-contract guard, and terminal claim separation.
Shared documentation remains a separate currentization surface:
docs/adr/README.mdstill lists ADR 0068 asAccepted, and the CHANGELOG/TRACEABILITY/product-gap authorities must be reconciled by the docs/queue-authority lane rather than treating this child comment as checked-in completion.Verification commands
cargo fmt --all -- --checkcargo test -p analysis_enginecargo clippy -p analysis_engine --all-targets -- -D warningspython3 scripts/validate_documentation.pyExact-head Checks only; no self-approval, bypass, force update, destructive rebase, coverage suppression, or predecessor evidence transfer.
Merge gate
Live organization ruleset 18156473 requires one qualifying current-head approval, stale-review dismissal on push, all review threads resolved, and central required workflows; non-fast-forward updates are prohibited. This PR stays Draft pending fold/consolidation and exact-head evidence.