build(deps): bump github/codeql-action/upload-sarif from 4.37.0 to 4.38.0 - #1221
dependabot[bot] wants to merge 7 commits into
Conversation
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.37.0 to 4.38.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@99df26d...b96794f) --- updated-dependencies: - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Noema LLM review
The PR updates github/codeql-action/upload-sarif from v4.37.0 to v4.38.0 in both .github/workflows/ossf-scorecard.yml and .github/workflows/security-audit.yml. The new pinned SHA b96794f015dfd88f77b49b1c93e0fa7110f94c63 matches the official v4.38.0 release, and the action invocation parameters are unchanged, so no behavioral regression is expected. One non-blocking issue: the comment in ossf-scorecard.yml still references v4.37.0 and should be updated for consistency.
Reviewed changed lines
.github/workflows/ossf-scorecard.yml:86 (RIGHT): The version bump updates the pinned SHA to b96794f015dfd88f77b49b1c93e0fa7110f94c63 (v4.38.0). Thewithblock (sarif_file) is unchanged, so no behavioral impact is expected. Note: the trailing comment still says '# v4.37.0 peeled commit' and should be updated..github/workflows/security-audit.yml:95 (RIGHT): The version bump updates the pinned SHA to b96794f015dfd88f77b49b1c93e0fa7110f94c63 (v4.38.0). Thewithblock (sarif_file) and theif: always()condition are unchanged, so no behavioral impact is expected.
Adversarial validation
.github/workflows/security-audit.yml:95 (RIGHT)falsified: The new SHA b96794f015dfd88f77b49b1c93e0fa7110f94c63 does not match the official v4.38.0 release of github/codeql-action/upload-sarif. — The SHA is confirmed as the official v4.38.0 release SHA for the action..github/workflows/ossf-scorecard.yml:86 (RIGHT)falsified: The version bump changes the action's behavior because thewithinputs are interpreted differently in v4.38.0 compared to v4.37.0. — The invocation parameters are identical; only the action version is updated. No behavioral regression is plausible.- Residual risk: Low. The SHA corresponds to the official v4.38.0 release and the action inputs are unchanged. The only minor issue is a stale comment in ossf-scorecard.yml that does not affect runtime behavior.
Findings
- [low] .github/workflows/ossf-scorecard.yml:86 (RIGHT): Stale comment: still says '# v4.37.0 peeled commit' but the pinned SHA is for v4.38.0. Update the comment to reflect the actual version to avoid confusion for future maintainers.
- Result: APPROVE
- Head SHA:
44da3c6ef8cd136f1a7cfaff39597004008851c2 - Reviewer credential:
noema-review-github-app-refresh - Actor:
cwl-noema-review[bot]
|
Fresh review on the existing canonical dependency PR found two repository-owned admission/traceability defects, both repaired without changing the upstream CodeQL Action pin beyond the intended 4.38.0 bump. First lineage:
Second live RED came from Dependabot itself on this PR: the GitHub Actions update configuration requested a The upload-sarif regression does not validate upstream tag-to-SHA mapping; dependency-review/supply-chain evidence remains authoritative for that. The Dependabot repair proves only that repository configuration no longer asks the service for the known-missing Current head is now |
|
@cwl-noema-review current exact |
There was a problem hiding this comment.
Noema LLM review
The PR updates github/codeql-action/upload-sarif from v4.37.0 (SHA 99df26d4…) to v4.38.0 (SHA b96794f0…) in both ossf-scorecard.yml and security-audit.yml, with the new SHA and version annotation consistent across the two workflows. A new regression test (test_workflow_action_annotation_policy.py) enforces that every upload-sarif reference carries a 40‑character SHA and a semantic-version annotation, and that all such references share one identity. The dependabot label removal (github-actions) is an unrelated cosmetic change that does not affect dependency bump correctness or automation behavior; it is not a blocking issue. All changes are safe to merge.
Reviewed changed lines
.github/workflows/ossf-scorecard.yml:86 (RIGHT): SHA pin updated from 99df26d4f13ea111d4ec1a7dddef6063f76b97e9 to b96794f015dfd88f77b49b1c93e0fa7110f94c63 with v4.38.0 annotation, matching the other workflow and the new test's single-identity requirement..github/workflows/security-audit.yml:95 (RIGHT): SHA pin updated to the same b96794f0… v4.38.0 identity as ossf-scorecard.yml; the regression test verifies this consistency.services/analysis-engine/tests/test_workflow_action_annotation_policy.py:1 (RIGHT): New regression test robustly enforces that all upload-sarif references contain a 40-char SHA and semantic version (lines 12‑16) and that all references share one identity (lines 49‑54). The test passes with the current updated workflows..github/dependabot.yml:41 (LEFT): Removal of the 'github-actions' label is an unrelated cosmetic change; no automation or consistency requirement depends on this label, and the change does not affect the upload-sarif pin update.
Adversarial validation
.github/workflows/ossf-scorecard.yml:86 (RIGHT)falsified: The upload-sarif update could introduce an inconsistency between the two workflow files that the regression test would not catch. — Both files now use b96794f015dfd88f77b49b1c93e0fa7110f94c63 with v4.38.0, so the single-identity assertion holds.services/analysis-engine/tests/test_workflow_action_annotation_policy.py:1 (RIGHT)falsified: The new test could be bypassed by a malformed upload-sarif line that the regex misses, allowing annotation drift. — The regex requires exactly a 40-hex SHA and a semantic version (lines 12‑16); the test asserts no incomplete lines and only one identity, and current workflows satisfy these conditions.- Residual risk: Low. The new test strengthens protection against upload-sarif annotation drift, but it does not cover dependabot label configuration; the label removal is non-blocking and does not affect the updated pin identity.
Findings
- No blocking findings.
- Result: APPROVE
- Head SHA:
1f4c500e11f821f640cb3ed4f80f737d1091c861 - Reviewer credential:
noema-review-github-app-refresh - Actor:
cwl-noema-review[bot]
|
Current-head repair note (2026-09-17): the predecessor I moved the PR back to Draft and repaired the PR-owned test on ordinary descendant |
Bumps github/codeql-action/upload-sarif from 4.37.0 to 4.38.0.
Release notes
Sourced from github/codeql-action/upload-sarif's releases.
Changelog
Sourced from github/codeql-action/upload-sarif's changelog.
... (truncated)
Commits
b96794fMerge pull request #4131 from github/update-v4.38.0-7e08580a902d5093Update changelog for v4.38.07e08580Merge pull request #4130 from github/henrymercer/workflow-runner-sizingbfcc52bRun slow macOS checks on larger runners8c251e7Merge pull request #4129 from github/update-bundle/codeql-bundle-v2.27.00b7ca40Add changelog note40484b3Update default bundle to codeql-bundle-v2.27.0977e6ceMerge pull request #4124 from github/henrymercer/toolcache-bundle-cleanup40a6b38Address toolcache cleanup review feedbackdeece8fApply suggestion from@henrymercerDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)