Skip to content

docs(agent-admission): keep ownership architecture code-current - #403

Merged
seonghobae merged 6 commits into
feat/agent-artifact-admissionfrom
codex/agent-admission-doc-current-red-20260913
Sep 13, 2026
Merged

docs(agent-admission): keep ownership architecture code-current#403
seonghobae merged 6 commits into
feat/agent-artifact-admissionfrom
codex/agent-admission-doc-current-red-20260913

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Child of #129. Documentation-contract repair only; no admission runtime/policy change and no sibling-owner implementation duplication.

Fresh review of exact parent #129@c9fbc8210b2703334d940871eae4f74547668ea1 found crates/agent-artifact-admission absent from docs/architecture.md, absent from the CLAUDE.md workspace layout (which still says two members), and absent from AGENTS.md ownership guidance. The architecture page also omits the foreign canonical-owner boundary.

Exact test-only head ee6c1adc58234a17322592585ea0783d1e84cf66 adds tests/agent_artifact_documentation_contract.rs and should RED until code-current docs name the shipped crate, Wardnet ownership, and external boundaries to quarantine-sandbox-runtime, EgressWeave, contextual-orchestrator, and appguardrail.

Minimum repair is docs/guidance only. Do not edit #361 PRD/TRD/UML, #111 ADR, #130 gap baseline, CGC/EA, central workflows, or foreign-owner source. Keep Draft until exact-head RED/GREEN and fresh checks/reviews/threads are proven.

Summary by CodeRabbit

  • 문서

    • Agent Artifact Admission 구성 요소와 외부 시스템 간 소유권 경계를 아키텍처 문서에 반영했습니다.
    • 워크스페이스 구성, 아티팩트·증거 바인딩 및 승인 정책 관련 안내를 업데이트했습니다.
    • 외부 시스템의 계약과 증거는 검증 대상으로 명확히 구분했습니다.
  • 테스트

    • 관련 문서에 구성 요소와 소유권 경계가 일관되게 반영되었는지 확인하는 검증을 추가했습니다.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

Failed to post review comments.

GitHub was unavailable or timed out while CodeRabbit was posting the review. Please request a new review later if the pull request still needs one. This happened while posting 1 inline comment. Use @coderabbitai full review to retry the review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: cb556d0c-afd5-4a53-bf11-17ef8dadd9bf

📥 Commits

Reviewing files that changed from the base of the PR and between c9fbc82 and da77a29.

📒 Files selected for processing (4)
  • AGENTS.md
  • CLAUDE.md
  • docs/architecture.md
  • tests/agent_artifact_documentation_contract.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: rust
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: ContextualWisdomLab/wardnet

Timestamp: 2026-09-13T09:11:15.046Z
Learning: Preserve Wardnet ownership of Agent Artifact Admission, gateway/SOC control-plane policy, and security evidence.
Learnt from: CR
Repo: ContextualWisdomLab/wardnet

Timestamp: 2026-09-13T09:11:15.046Z
Learning: Every PR runs a central **Security Scan** required gate: `osv-scan` + `dependency-review` (diff-scoped) and `trivy-fs` (repo-wide, CRITICAL/HIGH, fixable).
Learnt from: CR
Repo: ContextualWisdomLab/wardnet

Timestamp: 2026-09-13T09:11:06.538Z
Learning: run `cargo fmt --check` and `cargo test` before claiming code is ready
Learnt from: CR
Repo: ContextualWisdomLab/wardnet

Timestamp: 2026-09-13T09:11:06.538Z
Learning: Read `AGENTS.md` first
Learnt from: CR
Repo: ContextualWisdomLab/wardnet

Timestamp: 2026-09-13T09:11:15.046Z
Learning: Run `cargo fmt --check` and `cargo test` before claiming code is ready.
📝 Walkthrough

Walkthrough

Agent Artifact Admission이 세 번째 워크스페이스 크레이트로 문서화되었습니다. 아키텍처와 운영 문서에 Wardnet의 소유권 및 네 개 외부 시스템의 계약 검증 경계가 추가되었습니다. 문서 내용을 검증하는 테스트도 추가되었습니다.

Changes

Agent Artifact Admission 문서 갱신

Layer / File(s) Summary
아키텍처 및 소유권 경계
AGENTS.md, docs/architecture.md
아키텍처에 Agent Artifact Admission 크레이트와 네 개 외부 시스템의 external released evidence 연결을 추가했습니다. Wardnet이 승인 정책, 불변 아티팩트·증거 바인딩, 영수증을 소유하고 외부 시스템의 릴리스 계약과 증거만 검증하도록 문서화했습니다.
워크스페이스 및 운영 문서 검증
CLAUDE.md, tests/agent_artifact_documentation_contract.rs
워크스페이스를 세 개 크레이트로 갱신하고 Agent Artifact Admission의 역할과 외부 소유자 규칙을 추가했습니다. 테스트는 관련 문구의 존재와 이전 두-크레이트 문구의 부재를 확인합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 에이전트 아티팩트 승인 소유권과 아키텍처 문서를 최신 상태로 유지하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/agent-admission-doc-current-red-20260913

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
❌ Action failed

Review failed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae marked this pull request as ready for review September 13, 2026 09:14

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae
seonghobae merged commit ad74b91 into feat/agent-artifact-admission Sep 13, 2026
3 checks passed
@seonghobae
seonghobae deleted the codex/agent-admission-doc-current-red-20260913 branch September 13, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant