Repository navigation
Preserve document task progress when form fields need correction - #189
Open
madara-1112 wants to merge 1 commit into
Open
madara-1112 wants to merge 1 commit into
madara-1112 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Document tasks previously failed when delegated input contained an unknown PDF field or a value with the wrong type. Retrying reused the same invalid input, so the task failed again even after it had already found and checkpointed the source document.
This change validates delegated values against the PDF's actual field definitions before filling it. When only part of the input is invalid, the task now:
waiting_inputwith field-specific errors instead of failing;The implementation deliberately does not coerce strings such as
"true"into booleans. A value with the wrong type still requires an explicit correction.Verification
pnpm lintpnpm typecheckpnpm test(485 passed)pnpm build:serverpnpm build:webpnpm build:iospnpm build:androidpnpm --dir apps/worker typecheckRegression coverage includes both a wrong field type and an unknown field name, and verifies that no filled artifact is created until the invalid input is corrected.
Integration limits