Repository navigation
fix(figma): resolve optional dark colors independently - #49
Merged
Merged
Conversation
RAW references without dark values crashed variable preparation before the host could save them. Resolve an enabled dark value on its own and use the referenced dark color when available.
DavidBabinec
marked this pull request as ready for review
October 27, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
The bug
Saving a RAW color reference without a dark value crashed while preparing Figma variables. Dark colors also used the light value's format check, so mixed literal and referenced colors could be missing or incorrect.
The fix
Resolve dark values only when present and enabled, independently of the light value. Dark references use the source's dark color when available.
Verification
Nine export regressions cover missing dark values, transparency, and mixed light/dark formats. Six fail against the original source and all pass with the fix.
Notes
Figma Desktop was not exercised; validation covers variable preparation and the existing mocked host tests.