Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed

- Fixed importing a local font into WordPress failing with a Google Font download error. Custom fonts now upload the selected file directly instead of trying to find it on Google Fonts.
- Fixed Figma synchronization stopping when a RAW color referenced another variable without a dark-mode value. Light and dark colors now resolve independently, so mixed literal and referenced colors keep their correct values.
- Fixed Bricks sites hanging when removed Core Framework classes were cleaned up. The initial lookup joined post metadata five times, multiplying rows on sites with many metadata entries. It now checks all five Bricks metadata keys through one join while retaining the existing batched cleanup.
- Fixed transparent variants and shade/tint counts for RAW colors that reference another variable, such as `var(--bg-body)`. Generated variants now follow the current source color, while manually edited swatches are preserved. Older saved swatches without edit history are left unchanged on load; use Reset on a stale swatch to return it to automatic generation, then save to update the site's CSS.
Expand Down
13 changes: 10 additions & 3 deletions packages/wp/src/components/modules/fonts/FontsTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ export function FontsTab() {
if (!font.family) return;

try {
const files = await fetchGoogleFontFiles(font.family, selectedVariants);
const files =
font.category === "custom-font"
? font.files
: await fetchGoogleFontFiles(font.family, selectedVariants);
const resolvedFont = { ...font, files };
const id = `${font.title}-${font.family}-${selectedVariants.join(".")}`;
const variants = font.variants.reduce((acc: FontVariantData[], v: FontVariantData) => {
Expand All @@ -107,8 +110,12 @@ export function FontsTab() {
setActiveTab(USER_FONTS);
toast.success("Font added successfully");
} catch (error) {
console.error("Failed to download Google Font:", error);
toast.error("Could not download the selected Google Font");
console.error("Failed to import font:", error);
toast.error(
font.category === "custom-font"
? "Could not upload the selected custom font"
: "Could not download the selected Google Font",
);
}
};

Expand Down
98 changes: 98 additions & 0 deletions packages/www/src/__tests__/wpCustomFontImport.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
import { act, createElement, type ComponentType } from "react";
import { createRoot, type Root } from "react-dom/client";
import { Provider, createStore, type PrimitiveAtom } from "jotai";
import { toast } from "sonner";

// The WP shell has its own globals and aliases, checked by build:wp.
// Runtime imports keep that separate type environment out of the web build.
const { FontsTab } = require("../../../wp/src/components/modules/fonts/FontsTab") as { FontsTab: ComponentType };
const { fontsDataAtom } = require("../../../wp/src/state") as { fontsDataAtom: PrimitiveAtom<{ fonts: Record<string, unknown>[] }> };

jest.mock("../../../wp/src/state", () => {
const { atom } = jest.requireActual("jotai");
return { fontsDataAtom: atom({ fonts: [] }) };
});
jest.mock("../../../wp/src/components/ClassSectionHeading", () => ({ ClassSectionHeading: () => null }));
jest.mock("../../../wp/src/components/modules/fonts/components/FontsList", () => ({ FontsList: () => null }));
jest.mock("../../../wp/src/components/modules/fonts/ImportGoogleFonts", () => ({ ImportGoogleFonts: () => null }));
jest.mock("../../../wp/src/components/modules/fonts/ImportCustomFonts", () => ({
ImportCustomFonts: ({ setSelectedVariants, downloadFontsLocally }: { setSelectedVariants: (variants: string[]) => void; downloadFontsLocally: (font: unknown) => Promise<void> }) =>
createElement("div", null, createElement("button", {
onClick: () => {
setSelectedVariants(["400normal"]);
},
}, "Select file"),
createElement("button", { onClick: (event: Event) => {
event.stopPropagation();
return downloadFontsLocally({ family: "Local Test Font", title: "Local Test Font", category: "custom-font",
files: { "400normal": "data:font/woff2;base64,d09GMg==" },
variants: [{ id: "400normal", cssSelector: "", comment: "", fontDisplay: "auto" }],
customSelectors: "", customVariable: "" });
} }, "Add Font")),
}));
jest.mock("../../../wp/src/components/modules/fonts/utils/utils", () => {
Object.assign(globalThis, { TextEncoder: require("node:util").TextEncoder, TextDecoder: require("node:util").TextDecoder });
return jest.requireActual("../../../wp/src/components/modules/fonts/utils/utils");
});
jest.mock("sonner", () => ({ toast: { error: jest.fn(), success: jest.fn() } }));

(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
const originalFetch = globalThis.fetch;
let root: Root;
let container: HTMLDivElement;
let store: ReturnType<typeof createStore>;
const fetchMock = jest.fn();

beforeEach(async () => {
jest.clearAllMocks();
jest.spyOn(console, "error").mockImplementation(() => {});
globalThis.fetch = fetchMock;
Object.assign(window, {
coreframework: { core_api_url: "https://example.test/wp-json/core-framework/v2/" },
wpApiSettings: { nonce: "test-nonce" },
});
fetchMock.mockImplementation(async (url: string) => {
if (url.includes("googleapis.com")) throw new Error("This local font is not on Google Fonts");
return { ok: true, json: async () => ({ success: true }) };
});
store = createStore();
container = document.createElement("div");
root = createRoot(container);
await act(async () => root.render(createElement(Provider, { store }, createElement(FontsTab))));
});

afterEach(() => {
act(() => root.unmount());
globalThis.fetch = originalFetch;
jest.restoreAllMocks();
});

async function click(text: string) {
const button = [...container.querySelectorAll("button")].find((button) => button.textContent === text || button.firstChild?.textContent === text);
if (!button) throw new Error(`Missing button: ${text}`);
await act(async () => button.click());
}

test("uploads the selected local file without replacing it with a Google Fonts lookup", async () => {
await click("Import Local Font");
await click("Select file");
await click("Add Font");
expect(fetchMock).toHaveBeenCalledTimes(1);
expect(fetchMock).toHaveBeenCalledWith("https://example.test/wp-json/core-framework/v2/upload-fonts", expect.objectContaining({
method: "POST",
body: JSON.stringify({ fonts: [{ font_base64: "d09GMg==", filename: "Local-Test-Font-400normal.woff2" }] }),
}));
expect(store.get(fontsDataAtom).fonts).toEqual([expect.objectContaining({ family: "Local Test Font", category: "custom-font" })]);
expect(toast.success).toHaveBeenCalledWith("Font added successfully");
expect(toast.error).not.toHaveBeenCalled();
});

test("keeps a failed local upload out of the project and reports a custom-font error", async () => {
fetchMock.mockResolvedValue({ ok: false, status: 500 });
await click("Import Local Font");
await click("Select file");
await click("Add Font");
expect(store.get(fontsDataAtom).fonts).toEqual([]);
expect(toast.success).not.toHaveBeenCalled();
expect(toast.error).toHaveBeenCalledWith("Could not upload the selected custom font");
});
Loading