fix(catalog): drop stale vendored templates.json, document live loader - #83
Merged
Merged
Conversation
The rendered catalog already comes from cva-templates main via src/lib/data.ts (hourly ISR revalidation, counts derived with catalogStatsFrom); the vendored public/data copy was unreferenced and stale by construction. No repository_dispatch needed. Closes #75
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 5 | 0 | 0 | 0.04s | ||
| ✅ ACTION | zizmor | 5 | 0 | 0 | 2.06s | ||
| ✅ BASH | bash-exec | 1 | 0 | 0 | 0.01s | ||
| ✅ BASH | shellcheck | 1 | 0 | 0 | 0.34s | ||
| shfmt | 1 | 1 | 0 | 0.01s | |||
| ✅ COPYPASTE | jscpd | yes | no | no | 1.65s | ||
| ✅ EDITORCONFIG | editorconfig-checker | 174 | 0 | 0 | 0.44s | ||
| ✅ JAVASCRIPT | eslint | 1 | 0 | 0 | 2.23s | ||
| ✅ JAVASCRIPT | standard | 1 | 0 | 0 | 1.59s | ||
| ✅ JSON | jsonlint | 9 | 0 | 0 | 0.11s | ||
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.8s | ||
| ✅ JSON | prettier | 9 | 0 | 0 | 0.41s | ||
| ✅ JSON | v8r | 9 | 0 | 0 | 10.95s | ||
| ✅ MARKDOWN | markdownlint | 9 | 0 | 0 | 0.52s | ||
| markdown-table-formatter | 9 | 1 | 0 | 0.21s | |||
| ✅ REPOSITORY | betterleaks | yes | no | no | 1.08s | ||
| ✅ REPOSITORY | checkov | yes | no | no | 16.34s | ||
| ✅ REPOSITORY | git_diff | yes | no | no | 0.02s | ||
| ✅ REPOSITORY | osv-scanner | yes | no | no | 1.7s | ||
| ✅ REPOSITORY | secretlint | yes | no | no | 2.29s | ||
| ✅ REPOSITORY | trivy | yes | no | no | 14.7s | ||
| ✅ REPOSITORY | trufflehog | yes | no | no | 3.37s | ||
| ✅ SPELL | cspell | 175 | 0 | 0 | 4.24s | ||
| ✅ TSX | eslint | 100 | 0 | 0 | 4.09s | ||
| ✅ YAML | prettier | 13 | 0 | 0 | 0.6s | ||
| ✅ YAML | yamllint | 13 | 0 | 0 | 0.59s |
Detailed Issues
⚠️ MARKDOWN / markdown-table-formatter - 1 error
1 files contain markdown tables to format:
- README.md
⚠️ BASH / shfmt - 1 error
diff public/install.sh.orig public/install.sh
--- public/install.sh.orig
+++ public/install.sh
@@ -25,7 +25,10 @@
GITHUB_DOWNLOAD="${GITHUB_DOWNLOAD:-https://github.com}"
info() { printf '%s\n' "$*" >&2; }
-die() { printf 'error: %s\n' "$*" >&2; exit 1; }
+die() {
+ printf 'error: %s\n' "$*" >&2
+ exit 1
+}
need_cmd() {
command -v "$1" >/dev/null 2>&1 || die "required command not found: $1"
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,ACTION_ZIZMOR,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,COPYPASTE_JSCPD,EDITORCONFIG_EDITORCONFIG_CHECKER,JAVASCRIPT_ES,JAVASCRIPT_STANDARD,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_TRIVY,REPOSITORY_TRUFFLEHOG,SPELL_CSPELL,TSX_ESLINT,YAML_PRETTIER,YAML_YAMLLINT
Show us your support by starring ⭐ the repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #75. Verified the acceptance criteria against the code instead of adding dispatch machinery:
Type of Change
How Has This Been Tested?
Checklist
Closes #75