feat(web): full profile form, live catalog CRUD, and per-node drift#63
Merged
Conversation
Widen the web profile shape to mirror cryptos.v1.CertificateProfile: subject, typed SANs (dns/ip/email/uri), key and extended key usage, basic constraints, and a base64 extra-extensions editor. Wire live createProfile, updateProfile, and deleteProfile to the manager's new RPCs, branching on fleetMode() with the mock path unchanged and a refetch after each write. Admin-gate the create, edit, and delete controls and surface errors inline. Regenerate the fleet Connect stubs and add the profile-applied and profile-deleted audit kinds. Closes #62
Add a pure computeDrift that compares the catalog to a node's applied profiles by name and classifies each as in-sync, drifted, node-only, or not-applied, listing the differing fields for a drifted row in a deterministic order. Add a per-node drift view reachable from the node detail that fetches the node config live, computes drift, and offers an admin-gated Apply catalog version reconcile via ApplyProfileToNode with an inline error and a refetch. Node-only rows are informational. Refs #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Grows the profile catalog UI into a full, fleet-managed one and adds per-node drift.
Merge order: depends on CryptOS-PKI/api#60 (proto) and CryptOS-PKI/manager#49 (RPCs); merge api first, then manager, then this. The regenerated fleet Connect stubs are vendored here from the api change.
Closes #62
Part of #24
Verification
npm run lint)npm test: 173 passing)npm run build)How this was verified
npm run lint(eslint + prettier) clean;npm testall 173 tests pass including the widened mock/live CRUD round-trip, the four-state computeDrift unit tests, and the drift-view reconcile test;npm run build(tsc + vite) succeeds.