Conversation
…space docs: fix proofreading and whitespace issues
The setup script searched the downloaded templates for `$domainSquattingEnabled = 1 #`, but both Deploy and Detect ship the setting as `= 0 #`. Apply-Replacements matches with String.Contains, so the lookup missed, the pattern landed in $missing, and the script threw "Failed to customize the Deploy template" before writing any output files. This failed for every user regardless of the answers given at the prompts, and it was the only pattern of the 23 that did not match. Verified all 23 patterns against the current Deploy and Detect templates on main, then ran the replacement block end to end: every replacement applies and both generated scripts parse as valid PowerShell. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix(enterprise): correct domainSquattingEnabled replacement pattern
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows deployment setup default and improves documentation clarity across deployment, settings, troubleshooting, and detection guidance.
Changes:
- Corrects domain-squatting template replacement matching.
- Refines terminology, grammar, and formatting.
- Updates browser deployment and detection-rule instructions.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Summary | Final review comments |
|---|---|---|
enterprise/Setup-Windows-Chrome-and-Edge.ps1 |
Fixes template replacement matching. | — |
docs/troubleshooting/testing-check.md |
Clarifies phishing-link warning. | — |
docs/troubleshooting/common-issues.md |
Improves troubleshooting lists. | — |
docs/SUMMARY.md |
Corrects macOS capitalization. | — |
docs/settings/general.md |
Improves settings descriptions. | — |
docs/settings/detection-rules.md |
Clarifies detection-rule guidance. | Nit (1 vote): Load Current uses bundled rules rather than configured or cached rules. |
docs/settings/branding.md |
Refines branding documentation. | — |
docs/settings/activity-logs.md |
Clarifies activity-log guidance. | — |
docs/settings/about.md |
Updates Edge store naming. | — |
docs/removal/windows/chrome-edge.md |
Clarifies removal instructions. | — |
docs/README.md |
Improves overview wording. | — |
docs/firefox-support.md |
Standardizes Firefox deployment wording. | — |
docs/features/domain-squatting-detection.md |
Clarifies detection descriptions. | — |
docs/deployment/firefox-deployment.md |
Improves Firefox deployment instructions. | Nit (1 vote): The JSON only adds the extension to Uninstall, contrary to the text describing removal from Install or ExtensionSettings. |
docs/deployment/chrome-edge-deployment-instructions/windows/rmm-deployment.md |
Refines RMM instructions. | — |
docs/deployment/chrome-edge-deployment-instructions/windows/README.md |
Clarifies Windows deployment options. | — |
docs/deployment/chrome-edge-deployment-instructions/windows/manual-deployment.md |
Clarifies manual deployment and sideloading. | — |
docs/deployment/chrome-edge-deployment-instructions/windows/domain-deployment.md |
Improves Intune and policy instructions. | — |
docs/deployment/chrome-edge-deployment-instructions/macos.md |
Updates macOS deployment guidance. | Moderate (2 votes): The documented no-argument behavior conflicts with the script’s argument check. Critical (1 vote): The External Extensions directory creation condition fails on a fresh machine. |
docs/advanced/creating-detection-rules.md |
Clarifies rule creation and update guidance. | — |
Suppressed comments (2)
docs/deployment/firefox-deployment.md:480
- The JSON below adds
check@cyberdrain.comtoUninstall; it does not remove the extension fromInstallorExtensionSettingsas this sentence says. This mismatch could cause administrators to edit the wrong policy fields.
Remove the extension from `Install` and `ExtensionSettings`:
docs/settings/detection-rules.md:142
Load Currentdoes not load the configured or cached rules:loadCurrentRulesIntoPlayground()always fetches the bundledrules/detection-rules.json(options/options.js:664-668). With a custom rules URL, this description leads users to test a different ruleset than the extension uses; please describe the bundled-file behavior or change the button implementation.
1. You can use the `Load Current` button to pull in the configured detection rules for the browser. You can test them as-is or add or edit the rules JSON until you have the candidate rules you want to test.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </plist> | ||
| ``` | ||
| You could also deploy it in Chrome via command-line by creating the proper JSON object in the correct directory in the core /Library directory in macOS. Credit to @cezaraugusto for the script (slightly modified to simply install 'Check' if no parameter is passed...though technically you could pass any other Chrome extension ID after the script path and it would install that extension). | ||
| You could also deploy it in Chrome from the command line by creating the appropriate JSON object in the correct location under the core `/Library` directory in macOS. Credit goes to @cezaraugusto for the script, which was slightly modified to install Check when no parameter is passed. You can also pass another Chrome extension ID after the script path to install that extension. |
| </plist> | ||
| ``` | ||
| You could also deploy it in Chrome via command-line by creating the proper JSON object in the correct directory in the core /Library directory in macOS. Credit to @cezaraugusto for the script (slightly modified to simply install 'Check' if no parameter is passed...though technically you could pass any other Chrome extension ID after the script path and it would install that extension). | ||
| You could also deploy it in Chrome from the command line by creating the appropriate JSON object in the correct location under the core `/Library` directory in macOS. Credit goes to @cezaraugusto for the script, which was slightly modified to install Check when no parameter is passed. You can also pass another Chrome extension ID after the script path to install that extension. |
JohnDuprey
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.