Repository navigation
fix: use hashAlgorithm in PBES1 pattern - #1152
Open
aaronormerod wants to merge 1 commit into
Open
aaronormerod wants to merge 1 commit into
aaronormerod wants to merge 1 commit into
Conversation
RFC 8018 section 6.1 builds PBES1 on PBKDF1, which takes a hash algorithm, not a KDF. Fixes CycloneDX#906 Signed-off-by: aaronormerod <137795541+aaronormerod@users.noreply.github.com>
jkowalleck
added
the
cap: cryptography-registry
Contributor
|
LGTM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #906, the PBES1 variant pattern takes
{hashAlgorithm}instead of{kdf}. RFC 8018 section 6.1 builds PBES1 on PBKDF1, which is parameterised by a hash algorithm.Registry data only, no schema change. The family list is unchanged.
fixes #906