chore(deps): bump misc vendored deps (env, go-colorful, pkg/profile, kcp-go/v5, cron/v3) - #52
Open
moralpriest wants to merge 1 commit into
Conversation
Vendored dependency bumps (prep for eventual Go toolchain bump). All target go <= 1.17. - github.com/caarlos0/env/v6: v6.10.0 (go 1.17) - github.com/lucasb-eyer/go-colorful: v1.2.0 (go 1.12, adds hsluv) - github.com/pkg/profile: v1.7.0 (go 1.13) - github.com/xtaci/kcp-go/v5: v5.5.0 (go 1.13) — used by p2p + metrics - github.com/robfig/cron/v3: v3.0.1 (go 1.12, chain/parser fixes) Verification: - go build ./... green (kcp-go/v5 deps already vendored & compatible). - go test ./...: importers pass. Only pre-existing flaky walletapi failures (Test_Payload_TX, Test_Creation_TX_morecheck) — confirmed to fail identically on clean community-dev worktree.
8lecramm
reviewed
Aug 2, 2026
8lecramm
left a comment
8lecramm
left a comment
There was a problem hiding this comment.
github.com/xtaci/kcp-go/v5 was updated to 5.6.X during a previous pull request.
Could you please update the PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final batch of go<=1.17 vendored-dependency bumps (prep for eventual Go toolchain bump). All target
go <= 1.17— clean standalone PR.kcp-go/v5is used byp2p/controller.goandmetrics/metrics.go(daemon P2P transport); its transitive deps were already vendored and remain compatible.go-colorfulv1.2.0 adds thehsluvpackage.cron/v3v3.0.1 carries chain/parser bug fixes.Verification
go build ./...green.go test ./...: importers pass. Only pre-existing flaky walletapi failures (Test_Payload_TX,Test_Creation_TX_morecheck) — confirmed to fail identically on a cleancommunity-devworktree, so not a regression.Status of the go<=1.17 dependency-bump effort
With this PR, every vendored dependency that has a release compatible with
go 1.17has been bumped to its latest such version. Remaining items are intentionally deferred to the eventual go-directive bump phase:cespare/xxhash— consensus-critical (AstroBWTv3 PoW); v2.3.0 rewrites asm paths, needs full re-validation.tjfoc/gmsm— not imported by DERO (0 uses).blang/semver/v4,go.uber.org/atomic— already at latest go<=1.17 (no-ops).go-logr/zapr— requires logr v1.2.4 (PR chore(deps): bump go-logr/logr to v1.2.4 #46) which must land first.