fix: set integrator and getwork server - #56
Open
secretnamebasis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmd/simulatornever calledderodrpc.Getwork_server()— onlyderod's ownmain.godoes that — so the simulator had no getwork websocket listener atall, and no external miner could ever connect to it, regardless of transport
scheme. On top of that,
SendJob()builds its block template againstchain.IntegratorAddress(), which defaults toglobals.Config.Dev_Addresswhen unset; that address is never registered on a fresh simulator chain, so
template creation failed silently on every dispatch tick and produced an
empty job forever, with no diagnostic to point at the cause.
This PR adds the missing
Getwork_server()call and points the simulator'sintegrator address at its own genesis wallet, which is always registered on
a fresh chain. With both fixes, an external
dero-minerbinary can connectto a running simulator and mine against it end-to-end. Verified live: chain
height 1 → 120 with 331k+ miniblocks accepted by the real
Accept_new_block()validation path, confirming the simulator can nowactually serve its stated purpose ("helps in development and tests") for
miner-facing testing, not just wallet/RPC testing.
Fixes # (none filed — found while testing an unrelated AstroBWTv3 change
against the simulator)
Type of change
Which part is impacted?
Checklist:
License
I am contributing & releasing the code under DERO Research License (which
can be found here).