Feat/pipeline parallelize fastsync - #59
Open
secretnamebasis wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bootstrap_chain()'s--fastsyncstate-tree fetch (both the balance-tree phase and the smart-contract-tree phase) fetched onePeer.TreeSectionchunk at a time, waiting for each round-trip before requesting the next. This PR pipelines both phases: up to 16 concurrentPeer.TreeSectionrequests are in flight at once, with results drained in completion order rather than strict index order.Draining in completion order also fixes a real bug in a naive "just add concurrency" approach: waiting on requests in strict index order means one slow chunk head-of-line-blocks visibility into other chunks that already finished, which mostly cancels out the benefit of firing them concurrently in the first place. Chunk writes are commutative (each writes a disjoint key range into the same tree), so there's no ordering requirement — only the resume checkpoint needs to stay correct, which is now tracked via a low-water-mark instead of the last-fired index.
Only the network round-trips (
connection.Client.Call) run inside worker goroutines. AllgravitonTree/Snapshotreads and writes (GetTree,Put,Commit) stay on the single calling goroutine as results are drained — there is no concurrent access togravitonobjects at any point, since that thread-safety was never something I could verify.Live-tested against a real mainnet peer:
Fixes # (issue)
Type of change
Which part is impacted?
Checklist:
License
I am contributing & releasing the code under DERO Research License (which can be found here).