Skip to content

Fix/handshake log severity - #62

Open
secretnamebasis wants to merge 2 commits into
DEROFDN:community-devfrom
secretnamebasis:fix/handshake-log-severity
Open

Fix/handshake log severity#62
secretnamebasis wants to merge 2 commits into
DEROFDN:community-devfrom
secretnamebasis:fix/handshake-log-severity

Conversation

@secretnamebasis

@secretnamebasis secretnamebasis commented Aug 6, 2026

Copy link
Copy Markdown

Description

This one's the log-severity fix in dispatch_test_handshake(): .Error() calls bypass V(N) verbosity gating entirely (only .Info() respects it) — so a routine failed handshake, which happens constantly during normal peer probing/pruning, was always printed regardless of verbosity level, drowning out real errors. Changed to .V(4).Info(...) so it's gated like everything else at that noise level, same pattern as the fix already staged/committed in chain_sync.go.

Fixes # (issue)

Type of change

Please select the right one.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This will require a HardFork to be enabled

Which part is impacted ?

  • Wallet
  • Daemon
  • Miner
  • Explorer
  • Simulator
  • Misc (documentation, comments, text...)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

License

Im am contributing & releasing the code under DERO Research License (which can be found here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant