[int] Replace mysql escape_string with alternatives#8645
Open
sfayer wants to merge 1 commit into
Open
Conversation
Contributor
|
This would need to be backported, right? If we remove the mysql-client version pinning from DIRACOS2, then v8 and v9 would need to be compatible. |
Member
Author
|
Yep, it would need backporting for those reasons. If you're happy with it, I can make the backport branches/PRs. Regards, |
Contributor
|
Yes please. I will merge them all together. |
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This patch replaces the two calls to mysql-client's escape_string with suitable alternatives for DIRACGrid/DIRACOS2#190 .
I've run the integration tests successfully against the current DIRACOS2 version and one including mysqlclient-2.2.8 as well.
The only change of behaviour here is that the old __escapeString function in DIRAC MySQL would use double-quotes around the string, the new version uses single quotes. I've not found any case where this causes a problem.
Regards,
Simon
BEGINRELEASENOTES
*Core
FIX: Replace escape_string with alternatives
ENDRELEASENOTES