Skip to content

Added Version Match in linkage test, as well as OCC version macros - #2547

Merged
sandro-elsweijer merged 4 commits into
mainfrom
fix_occ_linkage
Oct 20, 2026
Merged

sandro-elsweijer merged 4 commits into
mainfrom
fix_occ_linkage

Conversation

@tunxu

@tunxu tunxu commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #2009

Applied same solution vor exposing VTK to OCC

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@tunxu tunxu linked an issue Oct 14, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.52%. Comparing base (417942b) to head (4a8c84d).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
+ Coverage   83.46%   83.52%   +0.06%     
==========================================
  Files         147      147              
  Lines       21911    21913       +2     
==========================================
+ Hits        18287    18302      +15     
+ Misses       3624     3611      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer sandro-elsweijer self-assigned this Oct 16, 2026
@sandro-elsweijer
sandro-elsweijer requested review from sandro-elsweijer and removed request for sandro-elsweijer October 16, 2026 12:45
Comment thread src/config.cmake.in
Comment thread src/config.cmake.in Outdated
Comment thread test/t8_gtest_occ_linkage.cxx Outdated
Comment thread src/CMakeLists.txt Outdated
@sandro-elsweijer
sandro-elsweijer added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit e90aa8f Oct 20, 2026
41 checks passed
@sandro-elsweijer
sandro-elsweijer deleted the fix_occ_linkage branch October 20, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: OCC lib header file with linkage macros

2 participants