Repository navigation
Enhancement: Make t8code around 16% faster - #2566
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 83.05% 83.54% +0.49%
==========================================
Files 139 147 +8
Lines 21573 21960 +387
==========================================
+ Hits 17917 18347 +430
+ Misses 3656 3613 -43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Davknapp
requested changes
Oct 15, 2026
Davknapp
left a comment
Collaborator
There was a problem hiding this comment.
I think the macro __builtin_unreachable is compiler specific. For our julia- wrapper we have to run it on windows, too.
Can you double-check if this is applicable to windows, too?
Davknapp
requested changes
Oct 15, 2026
Davknapp
left a comment
Collaborator
There was a problem hiding this comment.
I added some suggestions to make it more robust and not to trip over something that is only mentioned in the documentation in the future.
All in all: Very nice addition, thak you .
Davknapp
requested changes
Oct 19, 2026
Davknapp
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2567
Describe your changes here:
This PR uses the dispatch method rather than the std:visit method used before. This drastically reduces calls and lookups for the scheme functions.
To make this even more effective, it adds a build option, which links t8code internal functions at link time instead of runtime.
Running the time forest partition benchmark wit the following command results in the following runtimes:
Serial command
./t8_time_forest_partition -b -C -l3 -r3 -x0 -X1 -T1 -D0.1 -oParallel command
mpirun -np 8 ./t8_time_forest_partition -b -C -l3 -r3 -x0 -X1 -T1 -D0.1 -o -gAll these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).