Repository navigation
Other: Update googletest_mpi for updated EXPECT_NEAR - #2612
Merged
Merged
Conversation
EXPECT_NEAR called MPI_Allreduce before, which lead to a non-terminating test if not all processes had the same amount of elements.
Davknapp
marked this pull request as ready for review
October 20, 2026 13:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=======================================
Coverage 83.04% 83.04%
=======================================
Files 148 148
Lines 22153 22153
=======================================
Hits 18396 18396
Misses 3757 3757 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
holke
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2613
EXPECT_NEAR called MPI_Allreduce before, which lead to a non-terminating test if not all processes had the same amount of elements.
This updates googletest to use the version with the fix. This is a draft-PR until the fix is merged into googletest_with_mpi
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).