Fix Blog export dialog styling on DNN 10#228
Open
Forro-54 wants to merge 1 commit into
Open
Conversation
The Blog export dialog was being created correctly, but DNN 10 did not reliably apply the classes supplied through the legacy dialogClass option to the generated jQuery UI dialog wrapper. This caused the Export title, text, download link, and buttons to appear outside a properly styled popup. This change retrieves the generated dialog widget when it opens and applies the required DNN popup classes directly: dnnFormPopup dnnClear dnnBlogExportPopup The button-pane selectors were also scoped to the current Export dialog to avoid affecting other dialogs on the page. Tested successfully on: DNN 9.13.1 clean DNN 10.3.2 installation production DNN 10.3.2 installation Blog export and BlogML download Blog import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Export dialog was created correctly, but the DNN popup classes supplied through the legacy dialogClass option were not reliably applied to the generated jQuery UI dialog wrapper.
This caused the Export title, instructions, download link, and buttons to appear outside a properly styled popup.
Changes
Applies dnnFormPopup, dnnClear, and dnnBlogExportPopup directly to the generated dialog widget when it opens.
Retains the original dialogClass option for compatibility with older DNN and jQuery UI versions.
Scopes the Export and Cancel button selectors to the current Export dialog.
Testing
Tested successfully on:
DNN 9.13.1
clean DNN 10.3.2 installation
production DNN 10.3.2 installation
BlogML export and download
Blog import
This pull request changes only:
Server/Blog/Manage.ascx
Close #227