Skip to content

fix(web): criterion tabs and personas show an empty list with no message; earbud product page keeps a screen row #1553

Closed

Description

@JOY

Found in the live check of #1143 after promote #1552 (rate.vn main d7ab2edc, 2026-11-01). Read-only, Vietnamese locale, light and dark, 390 px and 1280 px.

Problem

#1143 (PR #1550) made per-criterion scores real or null. Today no published product has a criterion score, so:

  1. Empty leaderboard tabs with no explanation.
    • /leaderboard?cat=smartphones&criterion=camera, and every criterion tab (Màn hình, Hiệu năng, Camera, Pin, Đáng tiền) in every category, shows "Bảng xếp hạng toàn diện theo ngành hàng (0)" and an empty list.
    • The persona presets ("Chụp ảnh & quay vlog", "Gaming", "Pin trâu"…) and custom sliders empty the list the same way.
    • Nothing tells the shopper why.
  2. Earbuds still show a screen row on the product page. /earbuds/samsung-galaxy-buds3-pro: the review block "5 TIÊU CHÍ TRẢI NGHIỆM" lists "Màn hình & hiển thị: Chưa có". The leaderboard, versus and rank chips no longer show screen for earbuds (fix(web): per-criterion scores are derived from the star rating and saturate at 5.00 (ties, fake ranks) #1143), so the product page disagrees.

Expected

  1. When a criterion tab or persona has no scored product in the category, show an empty state such as "Chưa đủ dữ liệu cho tiêu chí này. Bảng sẽ có khi có điểm tiêu chí thật." with a link back to "Điểm tổng hợp". Alternatively, disable the tabs and personas that have no scored product, with that text as a tooltip.
  2. The product page's criterion block uses the category's criteria (no screen row for earbuds). It could read leaderboardCriteriaForCategory, or the per-category list from feat(shared-data): per-category rating criteria, weights and review form rules #1548 (P1 of design: weighted per-criterion star ratings, pros and cons per review, and a review value score #1531).

Not a problem

Size: XS to S. Area: web.

Activity

  1. added
    bugSomething isn't working
    status:readyTask ready to be picked up by an Agent
    status:in-progressTask currently claimed and being worked on by an Agent
    agent:webClaimed by Agent: Web
    and removed
    status:readyTask ready to be picked up by an Agent
    on Oct 31, 2026
  2. self-assigned this
    on Oct 31, 2026
  3. added
    status:in-reviewTask completed and waiting for review / PR merge
    status:doneTask completed and verified
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    status:in-reviewTask completed and waiting for review / PR merge
    on Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent:webClaimed by Agent: Webarea:webbugSomething isn't workingstatus:doneTask completed and verified

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions